Support sqlite and oracle connectors by HungKNguyen · Pull Request #750 · holistics/dbml

HungKNguyen · 2025-08-21T02:11:21Z

Continuation of #748

Changed the base branch to allow edits by maintainers

nguyenalter · 2025-08-21T05:01:31Z

Hi @HungKNguyen, could you check if your master branch is protected by any means? You may check it via https://github.com/hungknguyen/dbml/settings/branches.

If your master is protected, I cannot push commit to your forked repository

HungKNguyen · 2025-08-21T05:33:18Z

Hi @HungKNguyen, could you check if your master branch is protected by any means? You may check it via https://github.com/hungknguyen/dbml/settings/branches.

If your master is protected, I cannot push commit to your forked repository

@nguyenalter I'm not seeing any protection on the branch, are you having trouble pushing? Maybe you can double check the origin?

nguyenalter · 2025-08-21T09:20:35Z

Hi @HungKNguyen, could you check if your master branch is protected by any means? You may check it via https://github.com/hungknguyen/dbml/settings/branches.
If your master is protected, I cannot push commit to your forked repository

@nguyenalter I'm not seeing any protection on the branch, are you having trouble pushing? Maybe you can double check the origin?

When I try to push my commit to your forked repository, It shows 403 error:

git push HungKNguyen HEAD:master
remote: Permission to hungknguyen/dbml.git denied to nguyenalter.
fatal: unable to access 'https://github.com/hungknguyen/dbml/': The requested URL returned error: 403

I think you can either:

Add me as a collaborators in your forked repo
Try to checkout another branch (not master) in your forked repo and re-open another PR

@HungKNguyen please look into this, thank you for your time.

HungKNguyen · 2025-08-21T10:00:18Z

I think you can either:

Add me as a collaborators in your forked repo

Try to checkout another branch (not master) in your forked repo and re-open another PR

@HungKNguyen please look into this, thank you for your time.

@nguyenalter I just added you as a collaborator, thank you for your time as well

nguyenalter

Please also update the description in packages/dbml-cli/src/cli/index.js (see TODO) to introduce your new sqlite and oracle options

nguyenalter · 2025-08-21T11:27:29Z

packages/dbml-connector/src/connectors/oracleConnector.ts

@@ -0,0 +1,481 @@
+import * as oracledb from 'oracledb';


Please help add a comment to reference https://node-oracledb.readthedocs.io/en/latest/user_guide/installation.html#quickstart so we can check the doc more easily

nguyenalter · 2025-08-21T11:27:50Z

packages/dbml-connector/src/connectors/oracleConnector.ts

+  // Parse connection string to extract connection details
+  // Expected format: user/password@hostname/servicename
+  const regex = /^(.*?)\/(.*)@(.*)$/;
+  const match = connection.match(regex);
+
+  if (!match) {
+    throw new Error('Invalid Oracle connection string format. Expected: user/password@hostname/servicename');
+  }
+
+  const [, user, password, connectionString] = match;
+
+  // Set connection options
+  const connectionConfig: oracledb.ConnectionAttributes = {
+    user,
+    password,
+    connectString: connectionString,
+  };


Please move the parse connection string to a dedicated method, e.g:

parseConnectionString = (connection) => config

nguyenalter · 2025-08-21T11:28:43Z

packages/dbml-connector/src/connectors/sqliteConnector.ts

@@ -0,0 +1,389 @@
+import type { Database } from 'better-sqlite3';


Please help add https://github.com/WiseLibs/better-sqlite3/blob/master/docs/api.md#api to the start of this file for future reference

nguyenalter · 2025-08-21T11:29:17Z

packages/dbml-connector/src/connectors/sqliteConnector.ts

+  try {
+    return new DatabaseConstructor(connection, { readonly: true, fileMustExist: true });


To ensure the db is connected successfully, please try to run a simple query like this:

Suggested change

try {

return new DatabaseConstructor(connection, { readonly: true, fileMustExist: true });

try {

const db = new DatabaseConstructor(connection, { readonly: true, fileMustExist: true });

db.exec('SELECT 1');

return db;

nguyenalter · 2025-08-21T11:33:32Z

packages/dbml-connector/src/connectors/oracleConnector.ts

+    DATA_PRECISION,
+    DATA_SCALE,
+    NULLABLE,
+    DATA_DEFAULT,


https://docs.oracle.com/en/database/oracle/oracle-database/23/refrn/ALL_TAB_COLUMNS.html

Oracle DB v23 introduces DATA_DEFAULT_VC to get default value for the column. Could you improve the logic to retrieve the default value since using DATA_DEFAULT will always return the LONG type which will infer as number. This will cause expression like current_timestamp to be treated as number when converting to DBML which is incorrect.

My suggestion is to use DATA_DEFAULT_VC for Oracle DB >= 23 and fallback to DATA_DEFAULT for older versions.

nguyenalter · 2025-08-21T12:25:48Z

packages/dbml-connector/src/connectors/oracleConnector.ts

+  return {
+    name: COLUMN_NAME,
+    type: actualType,
+    dbdefault: getDbDefault(DATA_DEFAULT, defaultValueType),


You must ignore column with IDENTITY_COLUMN === 'YES' because it is mapped to increment option, we don't want to use the default auto-generated value from Oracle here.

Suggested change

dbdefault: getDbDefault(DATA_DEFAULT, defaultValueType),

dbdefault: `IDENTITY_COLUMN === 'YES' ? null : getDbDefault(DATA_DEFAULT, defaultValueType),

nguyenalter · 2025-08-21T12:28:29Z

packages/dbml-connector/src/connectors/oracleConnector.ts

+    SELECT
+      I.TABLE_NAME,
+      I.INDEX_NAME,
+      I.INDEX_TYPE,
+      I.UNIQUENESS,
+      IC.COLUMN_NAME,
+      IC.COLUMN_POSITION
+    FROM ALL_INDEXES I
+    JOIN ALL_IND_COLUMNS IC ON I.INDEX_NAME = IC.INDEX_NAME AND I.OWNER = IC.INDEX_OWNER
+    WHERE I.OWNER = :schemaName
+    ORDER BY I.TABLE_NAME, I.INDEX_NAME, IC.COLUMN_POSITION


Oracle will auto add index for primary key so you will need to exclude those auto-generated indexes from the DBML.

Suggested change

SELECT

I.TABLE_NAME,

I.INDEX_NAME,

I.INDEX_TYPE,

I.UNIQUENESS,

IC.COLUMN_NAME,

IC.COLUMN_POSITION

FROM ALL_INDEXES I

JOIN ALL_IND_COLUMNS IC ON I.INDEX_NAME = IC.INDEX_NAME AND I.OWNER = IC.INDEX_OWNER

WHERE I.OWNER = :schemaName

ORDER BY I.TABLE_NAME, I.INDEX_NAME, IC.COLUMN_POSITION

SELECT

I.TABLE_NAME,

I.INDEX_NAME,

I.INDEX_TYPE,

I.UNIQUENESS,

IC.COLUMN_NAME,

IC.COLUMN_POSITION

FROM ALL_INDEXES I

JOIN ALL_IND_COLUMNS IC ON I.INDEX_NAME = IC.INDEX_NAME AND I.OWNER = IC.INDEX_OWNER

JOIN ALL_CONSTRAINTS C ON I.INDEX_NAME = C.INDEX_NAME AND I.OWNER = C.OWNER AND C.CONSTRAINT_TYPE != 'P'

WHERE I.OWNER = :schemaName

ORDER BY I.TABLE_NAME, I.INDEX_NAME, IC.COLUMN_POSITION

HungKNguyen mentioned this pull request Aug 21, 2025

feat(dbml/connector): add sqlite and oracle connectors #748

Closed

4 tasks

nguyenalter requested review from huyphung1602 and nguyenalter August 21, 2025 04:44

nguyenalter reviewed Aug 21, 2025

View reviewed changes

HungKNguyen and others added 7 commits November 4, 2025 14:50

feat: add sqlite and oracle connectors

c091dac

feat(cli): add SQLite connector and update test workflow

a9d61df

misc(test): ensure table order match ddl script

07167ea

chore: addressing review

c3f1a78

ci: add workflow to test oracle connector

420566a

misc: add step to install sqlplus command

fdda49c

misc: update oracle connection

b9fd859

hdnax force-pushed the master branch from 6507503 to b9fd859 Compare November 4, 2025 07:55

hdnax changed the title ~~feat(dbml/connector): add sqlite and oracle connectors cont.~~ Support sqlite and oracle connectors Nov 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support sqlite and oracle connectors#750

Support sqlite and oracle connectors#750
HungKNguyen wants to merge 7 commits intoholistics:masterfrom
HungKNguyen:master

HungKNguyen commented Aug 21, 2025

Uh oh!

nguyenalter commented Aug 21, 2025

Uh oh!

HungKNguyen commented Aug 21, 2025

Uh oh!

nguyenalter commented Aug 21, 2025

Uh oh!

HungKNguyen commented Aug 21, 2025

Uh oh!

nguyenalter left a comment

Uh oh!

nguyenalter Aug 21, 2025

Uh oh!

nguyenalter Aug 21, 2025

Uh oh!

nguyenalter Aug 21, 2025

Uh oh!

nguyenalter Aug 21, 2025

Uh oh!

nguyenalter Aug 21, 2025

Uh oh!

nguyenalter Aug 21, 2025

Uh oh!

nguyenalter Aug 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

		@@ -0,0 +1,389 @@
		import type { Database } from 'better-sqlite3';

		try {
		return new DatabaseConstructor(connection, { readonly: true, fileMustExist: true });

-  try {
-    return new DatabaseConstructor(connection, { readonly: true, fileMustExist: true });
+  try {
+    const db = new DatabaseConstructor(connection, { readonly: true, fileMustExist: true });
+    db.exec('SELECT 1');
+    return db;

	dbdefault: getDbDefault(DATA_DEFAULT, defaultValueType),
	dbdefault: `IDENTITY_COLUMN === 'YES' ? null : getDbDefault(DATA_DEFAULT, defaultValueType),

Conversation

HungKNguyen commented Aug 21, 2025

Uh oh!

nguyenalter commented Aug 21, 2025

Uh oh!

HungKNguyen commented Aug 21, 2025

Uh oh!

nguyenalter commented Aug 21, 2025

Uh oh!

HungKNguyen commented Aug 21, 2025

Uh oh!

nguyenalter left a comment

Choose a reason for hiding this comment

Uh oh!

nguyenalter Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

nguyenalter Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

nguyenalter Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

nguyenalter Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

nguyenalter Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

nguyenalter Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

nguyenalter Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments