Skip to content

ARIA: allowlist important no-reply domains in promo filter #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
holoduke wants to merge 1 commit into
base: aria/filter-promo-senders-active-threads
Choose a base branch
from
Open

ARIA: allowlist important no-reply domains in promo filter #346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions backend/brain-prompt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,16 @@ function timeAgo(ts: number): string {
return `${days}d ago`;
}

// Promo / routine notification sender patterns. Used to drop noise participants
// from the active-threads surface — many of these accumulate under a single
// gmail:<account> thread key and crowd out real conversations. Raw observations
// remain logged; only the prompt-side aggregation is filtered.
// Filter senders from the active-threads surface so routine notifications don't
// crowd out real conversations. Raw observations stay logged; only the prompt-side
// aggregation is filtered.
// IMPORTANT_NOREPLY_DOMAINS: allowlist — domains where no-reply is the only channel for genuinely important mail (government, banks, employer HR). Checked first; overrides both lists below.
// PROMO_LOCAL_PATTERNS: local-part regexes matching routine/automated senders.
// PROMO_DOMAIN_KEYWORDS: domain substrings for known promo/marketplace senders.
const IMPORTANT_NOREPLY_DOMAINS: Set<string> = new Set([
"mijn.overheid.nl",
]);

const PROMO_LOCAL_PATTERNS: RegExp[] = [
/no-?reply@/i,
/do-?not-?reply@/i,
Expand All @@ -75,7 +81,6 @@ const PROMO_DOMAIN_KEYWORDS: string[] = [
"autoscout24",
"glassdoor",
"ferrari",
"mijn.overheid",
"marktplaats",
"quora",
];
Expand All @@ -84,8 +89,11 @@ function isPromoSender(sender: string): boolean {
if (!sender) return false;
const match = /<([^>]+)>/.exec(sender);
const addr = (match ? match[1] : sender).trim().toLowerCase();
if (PROMO_LOCAL_PATTERNS.some(re => re.test(addr))) return true;
const domain = addr.includes("@") ? addr.split("@")[1] || "" : addr;
for (const allowed of IMPORTANT_NOREPLY_DOMAINS) {
if (domain === allowed || domain.endsWith("." + allowed)) return false;
}
if (PROMO_LOCAL_PATTERNS.some(re => re.test(addr))) return true;
if (PROMO_DOMAIN_KEYWORDS.some(kw => domain.includes(kw))) return true;
return false;
}
Expand Down