fix(zk-passport): log verify failures in off-chain attestation endpoint#48
Merged
Conversation
The free gov-id off-chain attestation handler returned 400 from three branches (verify returned verified=false, missing disclosed fields, unsupported nationality) without logging, making these failures invisible in Datadog. The paid verify-and-issue endpoint already logs these; mirror that logging here so free-tier ZK Passport verification failures (and their queryResultErrors) are observable server-side. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The free gov-id off-chain attestation handler returned 400 from three branches (verify returned verified=false, missing disclosed fields, unsupported nationality) without logging, making these failures invisible in Datadog. The paid verify-and-issue endpoint already logs these; mirror that logging here so free-tier ZK Passport verification failures (and their queryResultErrors) are observable server-side.