294: Improve breaks and bins for probability chart#33
Open
cincodenada wants to merge 6 commits intoholtzy:masterfrom
Open
294: Improve breaks and bins for probability chart#33cincodenada wants to merge 6 commits intoholtzy:masterfrom
cincodenada wants to merge 6 commits intoholtzy:masterfrom
Conversation
For probability, I think breaks of 25 are more natural, and that revealed that the bin at 50 was 45-50, which was unintuitive, so I set an offset so that the bins are centered on multiples of 5, instead of those being the borders.
Author
|
After looking more closely, there are a few ways to accomplish the same bins - |
This is better than offset=-2.5 because it doesn't include the width twice
I'm not sure why I originally added the offset, but it seems to be not required
This is better I think
Actually, setting the min expansion to 0 is way better, so keep it. This reverts commit c395dd7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For probability, I think breaks of 25 are more natural, and that
revealed that the bin at 50 was 45-50, which was unintuitive, so I set
an offset so that the bins are centered on multiples of 5, instead of
those being the borders.