update angles and hjust of vertices in Circular Dendrogram#34
Open
PaulApivat wants to merge 1 commit intoholtzy:masterfrom
Open
update angles and hjust of vertices in Circular Dendrogram#34PaulApivat wants to merge 1 commit intoholtzy:masterfrom
PaulApivat wants to merge 1 commit intoholtzy:masterfrom
Conversation
Owner
|
Hi @PaulApivat, |
|
Hi @holtzy , I get the same problem as @PaulApivat as well, except that his pull request also did not solve the problem. The problem arises because of the location of the starting point of the dendrogram i.e. the location of subgroup 1. Your angle calculation assumes that the location is at the top. For some reason, I get it at 90 degrees. The entire circle is rotated and hence the angle of the label text gets screwed up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Update angles and hjust calculation for 339-circular-dendrogram-with-ggraph.Rmd
Why?
In the original version, the geom_node_text is hidden behind the node and not readable.
How?
I update the calculation for
vertices$angleandvertices$hjustand addedcoord_flip()method to the graph.Testing?
There are no unit tests. However, after I made the changes, I re-knitted the Rmarkdown document and the circular dendrogram now displays as intended.
Screenshot
Original circular dendrogram
New circular dendrogram