Fix AWS blocking call#119295
Conversation
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
| """Get available regions for a service.""" | ||
| session = AioSession() | ||
| return await session.get_available_regions(service) | ||
| return await hass.async_add_executor_job(session.get_available_regions, service) |
There was a problem hiding this comment.
We can't run a coro in the executor.
This probably needs to be fixed in the library itself or we can work around it by calling whatever its calling under the hood if its initializing / loading a cache from disk before this function so its not called in the event loop when this function does get called.
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
Reference: aio-libs/aiobotocore#1196 |
Breaking change
Proposed change
Fix following error:
2024-06-10 09:40:41.237 WARNING (MainThread) [homeassistant.util.loop] Detected blocking call to listdir inside the event loop by integration 'aws'
at homeassistant/components/aws/notify.py, line 38: return await session.get_available_regions(service) (offender: /usr/local/lib/python3.12/site-pa
ckages/botocore/loaders.py, line 311: api_versions = os.listdir(full_dirname)), please create a bug report at https://github.com/home-assistant/core
/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+aws%22
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: