Skip to content

Cloudflare R2 backup - Improved buffer handling#162958

Merged
zweckj merged 3 commits intohome-assistant:devfrom
patrickvorgers:cloudflare-r2-backup-provider-improved-buffer-handling
Feb 15, 2026
Merged

Cloudflare R2 backup - Improved buffer handling#162958
zweckj merged 3 commits intohome-assistant:devfrom
patrickvorgers:cloudflare-r2-backup-provider-improved-buffer-handling

Conversation

@patrickvorgers
Copy link
Copy Markdown
Contributor

Proposed change

The new IDrive-e2 S3 backup implementation introduces improved buffer handling using memoryview.
During the review of #144910, it was requested to apply the same approach to the other S3-compatible backup implementations.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: N/A
  • This PR is related to issue: Follow-up to IDrive e2 backup provider #144910 (request during review/merge to apply the same buffer handling to other S3-compatible backup implementations)
  • Link to documentation pull request: N/A
  • Link to developer documentation pull request: N/A
  • Link to frontend pull request: N/A

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @corrreia, mind taking a look at this pull request as it has been labeled with an integration (cloudflare_r2) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of cloudflare_r2 can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign cloudflare_r2 Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies improved buffer handling from the IDrive e2 backup implementation (#144910) to the Cloudflare R2 backup integration. The changes introduce memoryview-based buffer management with offset tracking to reduce memory copies during multipart uploads, improving performance for large backup files.

Changes:

  • Added memoryview-based buffer handling with offset tracking for multipart uploads
  • Implemented buffer compaction logic to avoid unnecessary memory copies
  • Added cast(Any, ...) for client method calls to handle type checking

Comment thread homeassistant/components/cloudflare_r2/backup.py Outdated
Comment thread homeassistant/components/cloudflare_r2/backup.py Outdated
Comment thread homeassistant/components/cloudflare_r2/backup.py Outdated
@corrreia
Copy link
Copy Markdown
Contributor

This looks good! A a solid improvement, especially for bigger backup sizes

@corrreia
Copy link
Copy Markdown
Contributor

Have you tested this with multipart uploads? R2 can be pretty finicky with those in my experience

@patrickvorgers
Copy link
Copy Markdown
Contributor Author

Have you tested this with multipart uploads? R2 can be pretty finicky with those in my experience

I tested it against idrive-e2 because I don't have Cloudflare-R2. Would be great if you could verify,
I didn't change anything in the different multipart sizes but it is good to double check.

Copy link
Copy Markdown
Member

@zweckj zweckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can be merged as soon as @corrreia confirms multi part

@corrreia
Copy link
Copy Markdown
Contributor

@zweckj confirmed, multipart works!

@zweckj zweckj merged commit 7a52d71 into home-assistant:dev Feb 15, 2026
32 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 16, 2026
@patrickvorgers patrickvorgers deleted the cloudflare-r2-backup-provider-improved-buffer-handling branch March 8, 2026 21:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants