Bump PyViCare to 2.60.1#169401
Conversation
|
Hey there @CFenner, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull request overview
Updates the Home Assistant vicare integration’s pinned PyViCare dependency to pick up upstream fixes/features from PyViCare 2.59.1 and 2.60.0.
Changes:
- Bump PyViCare from
2.59.0to2.60.0in thevicareintegration manifest. - Update generated dependency pin sets in
requirements_all.txtandrequirements_test_all.txtto match.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
requirements_test_all.txt |
Updates PyViCare pin used by the full test dependency set. |
requirements_all.txt |
Updates PyViCare pin used by the full runtime dependency set. |
homeassistant/components/vicare/manifest.json |
Updates the integration’s declared PyViCare requirement to 2.60.0. |
583d9dd to
39e08c6
Compare
|
I think we need a separate feature PR for the diagnostics change. |
39e08c6 to
79c273c
Compare
79c273c to
4e5edfe
Compare
TheJulianJES
left a comment
There was a problem hiding this comment.
Please update snapshots by running pytest /tests/components/vicare --snapshot-update and verify that the change in test_sensor.py::test_all_entities is correct: 53.0 vs 53. You can also check CI logs for the issue.
If CI is fixed, please mark the PR as ready again.
| 'last_reported': <ANY>, | ||
| 'last_updated': <ANY>, | ||
| 'state': '52', | ||
| 'state': '52.0', |
There was a problem hiding this comment.
Consider normalizing percentage-based humidity values so whole numbers don’t flip from "52" to "52.0" after the PyViCare bump, to avoid unnecessary state churn for users.
| 'state': '52.0', | |
| 'state': '52', |
| 'last_reported': <ANY>, | ||
| 'last_updated': <ANY>, | ||
| 'state': '53', | ||
| 'state': '53.0', |
There was a problem hiding this comment.
Consider normalizing percentage-based humidity values so whole numbers don’t flip from "53" to "53.0" after the PyViCare bump, as this creates unnecessary state changes and inconsistent formatting compared to other humidity sensors.
| 'state': '53.0', | |
| 'state': '53', |
There was a problem hiding this comment.
True, maybe we can use "native_display_precision".
Proposed change
Bump PyViCare from 2.59.0 to 2.60.1: openviess/PyViCare@2.59.0...2.60.1
This also includes 2.59.1 which was not bumped separately.
Changes in 2.59.1:
Changes in 2.60.0:
Changes in 2.60.1:
Release notes: https://github.com/openviess/PyViCare/releases/tag/2.60.1
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: