Skip to content

Bump PyViCare to 2.60.1#169401

Merged
frenck merged 2 commits into
home-assistant:devfrom
lackas:bump-pyvicare-2.60.0
Apr 29, 2026
Merged

Bump PyViCare to 2.60.1#169401
frenck merged 2 commits into
home-assistant:devfrom
lackas:bump-pyvicare-2.60.0

Conversation

@lackas
Copy link
Copy Markdown
Contributor

@lackas lackas commented Apr 28, 2026

Proposed change

Bump PyViCare from 2.59.0 to 2.60.1: openviess/PyViCare@2.59.0...2.60.1

This also includes 2.59.1 which was not bumped separately.

Changes in 2.59.1:

Changes in 2.60.0:

Changes in 2.60.1:

Release notes: https://github.com/openviess/PyViCare/releases/tag/2.60.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings April 28, 2026 19:12
@home-assistant home-assistant Bot added cla-signed dependency Pull requests marked as a dependency upgrade integration: vicare small-pr PRs with less than 30 lines. by-code-owner Quality Scale: No score labels Apr 28, 2026
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @CFenner, mind taking a look at this pull request as it has been labeled with an integration (vicare) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vicare can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign vicare Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Home Assistant vicare integration’s pinned PyViCare dependency to pick up upstream fixes/features from PyViCare 2.59.1 and 2.60.0.

Changes:

  • Bump PyViCare from 2.59.0 to 2.60.0 in the vicare integration manifest.
  • Update generated dependency pin sets in requirements_all.txt and requirements_test_all.txt to match.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
requirements_test_all.txt Updates PyViCare pin used by the full test dependency set.
requirements_all.txt Updates PyViCare pin used by the full runtime dependency set.
homeassistant/components/vicare/manifest.json Updates the integration’s declared PyViCare requirement to 2.60.0.

Copy link
Copy Markdown
Contributor

@CFenner CFenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lackas lackas force-pushed the bump-pyvicare-2.60.0 branch from 583d9dd to 39e08c6 Compare April 28, 2026 20:12
@CFenner
Copy link
Copy Markdown
Contributor

CFenner commented Apr 28, 2026

I think we need a separate feature PR for the diagnostics change.

Copilot AI review requested due to automatic review settings April 28, 2026 20:39
@lackas lackas force-pushed the bump-pyvicare-2.60.0 branch from 39e08c6 to 79c273c Compare April 28, 2026 20:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@lackas lackas requested a review from CFenner April 28, 2026 21:20
@lackas lackas changed the title Bump PyViCare to 2.60.0 Bump PyViCare to 2.60.1 Apr 28, 2026
@lackas lackas force-pushed the bump-pyvicare-2.60.0 branch from 79c273c to 4e5edfe Compare April 28, 2026 21:21
@lackas lackas requested a review from Copilot April 28, 2026 21:22
Copy link
Copy Markdown
Contributor

@CFenner CFenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Copy link
Copy Markdown
Member

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update snapshots by running pytest /tests/components/vicare --snapshot-update and verify that the change in test_sensor.py::test_all_entities is correct: 53.0 vs 53. You can also check CI logs for the issue.

If CI is fixed, please mark the PR as ready again.

@TheJulianJES TheJulianJES marked this pull request as draft April 29, 2026 03:15
@lackas lackas marked this pull request as ready for review April 29, 2026 05:48
Copilot AI review requested due to automatic review settings April 29, 2026 05:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

'last_reported': <ANY>,
'last_updated': <ANY>,
'state': '52',
'state': '52.0',
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider normalizing percentage-based humidity values so whole numbers don’t flip from "52" to "52.0" after the PyViCare bump, to avoid unnecessary state churn for users.

Suggested change
'state': '52.0',
'state': '52',

Copilot uses AI. Check for mistakes.
'last_reported': <ANY>,
'last_updated': <ANY>,
'state': '53',
'state': '53.0',
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider normalizing percentage-based humidity values so whole numbers don’t flip from "53" to "53.0" after the PyViCare bump, as this creates unnecessary state changes and inconsistent formatting compared to other humidity sensors.

Suggested change
'state': '53.0',
'state': '53',

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, maybe we can use "native_display_precision".

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @lackas 👍

../Frenck

                       

Blogging my personal ramblings at frenck.dev

@frenck frenck merged commit fe0da5c into home-assistant:dev Apr 29, 2026
51 of 52 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cla-signed dependency Pull requests marked as a dependency upgrade integration: vicare Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants