Remove name selection

[mikewoudenberg]

Proposed change

Remove name field from loqed config flow by letting the user select the lock from a list.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes Remove name field from loqed config flow #168935

Checklist

• I understand the code I am submitting and can explain how it works.
• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.
• Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[Copilot]

Pull request overview

This PR updates the loqed integration config flow to stop asking the user to enter a lock name, instead selecting the lock from the user’s LOQED account.

Changes:

• Remove the name field from the LOQED config flow and add a pick_lock step when multiple locks are found.
• Update config entry title to use the lock name returned by the API.
• Bump loqedAPI dependency to 2.1.11 and adjust tests/strings accordingly.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
homeassistant/components/loqed/config_flow.py	Removes name input, adds lock picker step, and sets entry title from selected lock.
homeassistant/components/loqed/strings.json	Updates config flow strings: removes name prompt, adds lock selection step + new errors.
tests/components/loqed/test_config_flow.py	Updates tests for new flow behavior (title changes, picker step, new data expectations).
homeassistant/components/loqed/manifest.json	Bumps loqedAPI requirement to 2.1.11.
requirements_all.txt	Bumps loqedAPI to 2.1.11.
requirements_test_all.txt	Bumps loqedAPI to 2.1.11.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

[erwindouna]

Suggested change

Please comment the why, not the what. :)

[erwindouna]

We only use this to transfer over this to async_step_pick_lock? Why not pass the user_input at this line.
If I understood the flow correctly, this would reduce a private variable you can reduce. What do you think? :)

[mikewoudenberg]

It's also used in the validate_input function to save a second call to the cloud api, any way I can improve it with that constraint?

[erwindouna]

I only spot the self._api_token in the zeroconf flow and step_pick_lock. Am I overlooking it? Can you link it?

[mikewoudenberg]

Sorry, was looking at the wrong variable. I attempted your suggestion, but I ended up needing to store the user Input in the configflowcontext (becuase the step gets called again after the user submits the form, and not having it in context would result in the validate input step failing ) resulting in more complexity than simply storing it in an instance variable.

[erwindouna]

Ah, there's the caveat. Thanks for checking @mikewoudenberg, so it has a good usecase this way - all good. :)

[erwindouna]

These patching is reused in multiple tests. Why not add this to conftest, so it be loaded in as a pytest fixture? :)