Skip to content

De-duplicate code to build Tuya device info#169899

Merged
erwindouna merged 2 commits intodevfrom
epenet/20260506-1252
May 6, 2026
Merged

De-duplicate code to build Tuya device info#169899
erwindouna merged 2 commits intodevfrom
epenet/20260506-1252

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented May 6, 2026

Proposed change

Just making sure that the code is shared to avoid future divergence

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings May 6, 2026 10:56
@home-assistant home-assistant Bot added cla-signed code-quality integration: tuya small-pr PRs with less than 30 lines. Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage Top 50 Integration is ranked within the top 50 by usage Quality Scale: No score labels May 6, 2026
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented May 6, 2026

Hey there @tuya, @zlinoliver, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tuya can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tuya Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Tuya integration to centralize device registry metadata construction in a shared helper, reducing duplication and risk of future drift.

Changes:

  • Added get_device_info() helper in homeassistant/components/tuya/util.py to build a DeviceInfo payload (with an initial=True mode for “unsupported” model labeling).
  • Updated TuyaEntity to set _attr_device_info from the shared helper instead of implementing its own device_info property.
  • Updated the coordinator device registration path to reuse the same helper when creating the device registry entry.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
homeassistant/components/tuya/util.py Introduces shared get_device_info() helper returning DeviceInfo for consistent device registry data.
homeassistant/components/tuya/entity.py Uses _attr_device_info = get_device_info(device) and removes duplicated device_info implementation.
homeassistant/components/tuya/coordinator.py Replaces inline device registry fields with **get_device_info(device, initial=True) during device registration.

Copy link
Copy Markdown
Member

@erwindouna erwindouna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @epenet!

@erwindouna erwindouna merged commit bbe00ef into dev May 6, 2026
33 checks passed
@erwindouna erwindouna deleted the epenet/20260506-1252 branch May 6, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed code-quality integration: tuya Quality Scale: No score small-pr PRs with less than 30 lines. Top 50 Integration is ranked within the top 50 by usage Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants