De-duplicate code to build Tuya device info#169899
Merged
erwindouna merged 2 commits intodevfrom May 6, 2026
Merged
Conversation
Contributor
|
Hey there @tuya, @zlinoliver, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Tuya integration to centralize device registry metadata construction in a shared helper, reducing duplication and risk of future drift.
Changes:
- Added
get_device_info()helper inhomeassistant/components/tuya/util.pyto build aDeviceInfopayload (with aninitial=Truemode for “unsupported” model labeling). - Updated
TuyaEntityto set_attr_device_infofrom the shared helper instead of implementing its owndevice_infoproperty. - Updated the coordinator device registration path to reuse the same helper when creating the device registry entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
homeassistant/components/tuya/util.py |
Introduces shared get_device_info() helper returning DeviceInfo for consistent device registry data. |
homeassistant/components/tuya/entity.py |
Uses _attr_device_info = get_device_info(device) and removes duplicated device_info implementation. |
homeassistant/components/tuya/coordinator.py |
Replaces inline device registry fields with **get_device_info(device, initial=True) during device registration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Just making sure that the code is shared to avoid future divergence
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: