Skip to content

Exclude incompatible entities from temperature automations#169901

Merged
frenck merged 1 commit intodevfrom
temperature_automations_exclude_incompatible_entities
May 6, 2026
Merged

Exclude incompatible entities from temperature automations#169901
frenck merged 1 commit intodevfrom
temperature_automations_exclude_incompatible_entities

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

Proposed change

Exclude incompatible entities from temperature automations

This means climate, water_heater and weather entities without temperature attribute won't block last checks for triggers or all checks for conditions.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented May 6, 2026

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (temperature) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of temperature can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign temperature Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the temperature automation trigger and condition logic so that attribute-based temperature entities (climate, water_heater, weather) that do not currently expose a temperature attribute are excluded from any/all-style evaluations, preventing them from blocking behavior=last triggers and behavior=all conditions.

Changes:

  • Add _should_include() overrides to filter out attribute-based entities that lack the configured temperature attribute.
  • Align temperature trigger and condition behavior by applying the same inclusion rules in both paths.
  • Update temperature trigger/condition tests to reflect and validate the new “attribute required” filtering behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
homeassistant/components/temperature/trigger.py Excludes attribute-sourced entities missing the temperature attribute from all/count evaluations used by behavior=first/last.
homeassistant/components/temperature/condition.py Applies the same inclusion filtering to prevent missing-attribute entities from blocking behavior=all conditions.
tests/components/temperature/test_trigger.py Updates parametrized trigger tests to expect missing attribute states to be excluded (via attribute_required=True).
tests/components/temperature/test_condition.py Updates parametrized condition tests to expect missing attribute states to be excluded (via attribute_required=True).

@frenck frenck merged commit 5f1201d into dev May 6, 2026
37 checks passed
@frenck frenck deleted the temperature_automations_exclude_incompatible_entities branch May 6, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants