Release 2.7.2: fix endpoint support check pipeline leak#86
Conversation
…ipeline - Add Out-Null pipe to Test-NinjaOneEndpointSupport calls in all request wrapper functions - Fixes issue where cmdlets returned arrays with spurious boolean as first element - Affected functions: New-NinjaOneGETRequest, New-NinjaOnePOSTRequest, New-NinjaOnePUTRequest, New-NinjaOnePATCHRequest, New-NinjaOneDELETERequest
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
=========================================
+ Coverage 9.90% 18.04% +8.13%
=========================================
Files 281 313 +32
Lines 3996 4256 +260
=========================================
+ Hits 396 768 +372
+ Misses 3600 3488 -112
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
There was a problem hiding this comment.
Pull request overview
This PR prepares the NinjaOne PowerShell module for release 2.7.2, primarily addressing a PowerShell output pipeline leak where endpoint support checks could emit boolean values into cmdlet output.
Changes:
- Suppress
Test-NinjaOneEndpointSupportreturn values in request wrapper functions by piping toOut-Null. - Update module manifest version to 2.7.2.
- Add a 2.7.2 entry to
CHANGELOG.mddescribing the fix.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Source/Private/New-NinjaOnePUTRequest.ps1 | Suppresses endpoint support check output via Out-Null. |
| Source/Private/New-NinjaOnePOSTRequest.ps1 | Suppresses endpoint support check output, but introduces a syntax error (unbalanced braces) that must be fixed. |
| Source/Private/New-NinjaOnePATCHRequest.ps1 | Suppresses endpoint support check output, but introduces a syntax error (extra else block) that must be fixed. |
| Source/Private/New-NinjaOneGETRequest.ps1 | Suppresses endpoint support check output via Out-Null. |
| Source/Private/New-NinjaOneDELETERequest.ps1 | Suppresses endpoint support check output and adds type-guarding around .results/.result access. |
| Source/NinjaOne.psd1 | Bumps ModuleVersion from 2.7.1 to 2.7.2. |
| CHANGELOG.md | Adds a 2.7.2 changelog entry documenting the pipeline leak fix. |
Summary
Validation