Skip to content

fixed: handels()#157

Open
direkkakkar319-ops wants to merge 1 commit intohoneynet:v2.0from
direkkakkar319-ops:bug_dicom_handlers.py
Open

fixed: handels()#157
direkkakkar319-ops wants to merge 1 commit intohoneynet:v2.0from
direkkakkar319-ops:bug_dicom_handlers.py

Conversation

@direkkakkar319-ops
Copy link
Copy Markdown

@direkkakkar319-ops direkkakkar319-ops commented Mar 31, 2026

fixes: #143

made

  self, event
    ) -> Generator[Tuple[int, Optional[Dataset]], None, None]:

        assoc = event.assoc
        identifier = event.identifier
        addr = assoc.requestor.address
        port = assoc.requestor.port
        yield (str(addr), port)

now the assoc is used after the declaration

test cases pass locally
Screenshot 2026-03-31 134221

@direkkakkar319-ops direkkakkar319-ops marked this pull request as ready for review March 31, 2026 17:45
@direkkakkar319-ops
Copy link
Copy Markdown
Author

Hi, @RicYaben should i close this PR as the issue related to the PR is also closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: in dicom_handlers.py assoc is used before it is defined

1 participant