fix(dashboard): anchor forecast series and correct fan chart trace layering - #23
Open
dkconnect wants to merge 1 commit into
Open
fix(dashboard): anchor forecast series and correct fan chart trace layering#23dkconnect wants to merge 1 commit into
dkconnect wants to merge 1 commit into
Conversation
…yering 1. Shifted future business day generation by +1 BDay and prepended to p50, p10, and p90 using np.insert(), so it elminated duplicate timestamps and visual step discontinuity at the boundary. 2. Replaced deprecated DatetimeIndex.append() with .union() to prevent runtime Future Warning. 3. and I reordered Plotly trace definitions to draw the semi-transparent 10%–90% CI polygon first so making sure the historical and median forecast lines render sharply on top.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shifted future business day generation by +1 BDay and prepended to p50, p10, and p90 using np.insert(), so it elminated duplicate timestamps and visual step discontinuity at the boundary.
Replaced deprecated DatetimeIndex.append() with .union() to prevent runtime Future Warning.
and I reordered Plotly trace definitions to draw the semi-transparent 10%–90% CI polygon first so making sure the historical and median forecast lines render sharply on top.