Skip to content

Adding support to absolute path. Tested on Bun.#3383

Closed
cj-1010-1414 wants to merge 3 commits into
honojs:mainfrom
cj-1010-1414:serve-static-absolute-path
Closed

Adding support to absolute path. Tested on Bun.#3383
cj-1010-1414 wants to merge 3 commits into
honojs:mainfrom
cj-1010-1414:serve-static-absolute-path

Conversation

@cj-1010-1414

@cj-1010-1414 cj-1010-1414 commented Sep 4, 2024

Copy link
Copy Markdown

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@yusukebe

yusukebe commented Sep 5, 2024

Copy link
Copy Markdown
Member

Hi @cj-1010-1414

It is not a bug that the serve static does not support an absolute path. It's intended. Regarding supporting the absolute path, we are considering how we should support it. Either way, this will affect current user who uses this feature as a breaking change.

@cj-1010-1414

Copy link
Copy Markdown
Author

Hope soon Hono support both relative and absolute path

@yusukebe

yusukebe commented Sep 6, 2024

Copy link
Copy Markdown
Member

@cj-1010-1414

Okay. I'll work on it after releasing the next minor version.

@yusukebe

Copy link
Copy Markdown
Member

This feature is implemented in #3420. Thanks!

@yusukebe yusukebe closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants