fix: don't reject with unusable body when full body was received#373
fix: don't reject with unusable body when full body was received#373BlankParticle wants to merge 1 commit into
Conversation
0918a3c to
9367bbd
Compare
|
Hi @BlankParticle, |
|
Hi @BlankParticle, Thank you for working on this. I confirmed that this PR fixes #370. Using the HTTP/1 parser's That said, a few behaviors make me hesitant to merge it as-is:
I'd like to proceed with the fix from my existing branch instead, which also covers these cases and body-reading paths. I incorporated the parts of this PR that I found valuable in 138386d and 0007a09, and credited you as a co-author on both commits. The scenarios covered by this PR are covered on that branch as well. I hope this approach works for you, and I'd be glad to have your review there. #375 |
|
Hi @usualoma, |
fixes #370
premature client disconnects now don't reject with
TypeError: Body is unusableif full body was receivedfor partial body, the rejection message is also made clearer
The test case and initial patch was written by Claude Fable 5 (medium)
I reviewed the code and test cases, manually tested, rewrote some of the stuff and added the normalised abort message