ci: fix publish smoke test path after monorepo restructure - #189
Merged
Conversation
The publish workflow's 'Run SDK tests' steps kept the pre-monorepo ../../tests/ relative path while their working-directory was later set to the workspace root, so pytest resolved two levels above the checkout and found nothing. The workflow had never executed (release-please tags use GITHUB_TOKEN and cannot trigger it), so the rot was invisible until the first dry-run dispatch (run 30891434754). Align with ci.yml, which runs 'pytest tests/' from the repo root. Part of the #178 publish-path validation.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The publish workflow's two "Run SDK tests" steps kept the pre-monorepo
../../tests/relative path while theirworking-directorywas later set to the workspace root, so pytest resolved two levels above the checkout and failed with "file or directory not found". Because release-please tags are created withGITHUB_TOKENand cannot trigger this workflow, it had never executed — the first-ever dry-run dispatch (run 30891434754) surfaced the rot.Fix: run
pytest tests/from the repo root, matching the green invocation inci.yml.Validation: dry-run dispatch of this branch — run 30891657918 (package=both, dry_run=true) exercising typecheck, compatibility gate, coverage gate, full test suite, and
hatch buildend to end.Part of the #178 publish-path validation (PyPI trusted publishing).