ci: bind PyPI publish jobs to per-package environments - #191
Merged
Conversation
PyPI rejects two pending trusted publishers with an identical repo/workflow/environment tuple, so the honua-sdk and honua-admin publishers could not both be registered against the bare workflow. Bind each publish job to its own GitHub environment (pypi-honua-sdk, pypi-honua-admin) so the two OIDC configurations are distinct.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyPI refused the second pending trusted publisher: two pending publishers cannot share an identical repo/workflow/environment configuration, and both of ours pointed at
publish-python-sdk.ymlwith no environment. Each publish job now runs in its own GitHub environment (pypi-honua-sdk,pypi-honua-admin— both created in repo settings, no protection rules), so the publishers register with distinct tuples. Environment names are also reflected in the workflow comments.No behavior change for CI lanes; the environments carry no secrets or approvals. Publisher registration on PyPI should use the matching environment name per package.
Refs #178