fix(imp): prevent search and subscribe PHP warnings#84
Merged
Conversation
Normalize IMP_Search_Query mailbox lists to IMP_Mailbox objects before deduplicating, avoiding array_unique() keeping string entries. Ensure subscribe() always sets a success notification when the parent mailbox action succeeded but all subfolder attempts were ignored.
ralflang
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IMP_Search_Querymailbox lists toIMP_Mailboxobjects before deduplicationIMP_Mailbox::subscribe()always sets a success notification when the parent mailbox action succeededMotivation
array_unique(..., SORT_REGULAR)could keep mailbox path strings instead ofIMP_Mailboxobjects when the same mailbox appeared as both, causingAttempt to read property "container" on stringin search query building. Withsubfolders: true, ignored subfolder subscribe errors left$notifyundefined even though the parent mailbox subscribe/unsubscribe had already succeeded.Changes
mboxeslist by normalizing throughIMP_Mailbox::get()and deduplicating by mailbox nameTest plan