fix(security): prevent path traversal in HTML compose img src handler [CVE-2026-58451]#85
Merged
Conversation
…CVE-2026-58451] The smiley resolver in IMP_Compose::_convertToRelated() prefix-checked img src URLs with stripos() and rebuilt the filesystem path with str_replace(), leaving any ../ sequences intact. A crafted <img src> in a composed message could read arbitrary web-server-readable files and exfiltrate them in the outgoing MIME body. Tighten the prefix to `/ckeditor/`, reject dot segments, NUL bytes, and non-allowlisted characters in the URL tail, and require realpath() containment under the resolved ckeditor directory before file_get_contents(). Reported by evan. Coordinated by VulnCheck.
Contributor
|
hello @ralflang thanks |
Member
Author
|
Hi @cheese1 I haven't validated - I don't have any H5 / IMP 6 instances anymore. If you would care to test I would backport it but I am not sure I can create a proper pear tgz still. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The smiley resolver in IMP_Compose::_convertToRelated() prefix-checked![]()
img src URLs with stripos() and rebuilt the filesystem path with
str_replace(), leaving any ../ sequences intact. A crafted
in a composed message could read arbitrary web-server-readable files
and exfiltrate them in the outgoing MIME body.
Tighten the prefix to
/ckeditor/, reject dot segments, NUL bytes,and non-allowlisted characters in the URL tail, and require
realpath() containment under the resolved ckeditor directory before
file_get_contents().
Reported by evan. Coordinated by VulnCheck.