Repository navigation
Fix Kira crashing at start: perfsweep exports an empty commands list - #160
Merged
Merged
Conversation
bot.js maps every feature's commands; perfsweep (#159) had none, so commands.map hit undefined.toJSON() on clientReady and Kira crashed since 16:27Z. A test now checks every feature bot.js loads exports a commands array. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kira has been crashing at start since #159 deployed (16:27Z):
bot.jsbuilds the slash commands withFEATURES.flatMap((f) => f.commands), andperfsweep.jsexported nocommands, socommands.map((c) => c.toJSON())threw onclientReady.perfsweep.jsexportscommands = [].FEATURESfrombot.jsand checks that every feature exports acommandsarray. It fails without the fix.node --test test/perfsweep.test.js: 2 pass.🤖 Generated with Claude Code