fix(crypto): route settlement through USDT fee slot (testnet workaround) - #100
Merged
Conversation
The deployed Base Sepolia Diamond has the real USDC token registered under the USDT (4) FeeType slot; USDC (5) is unset, so mintTicket(…, USDC, …) reverts TokenAddressZero() and Circle never submits the mint (approve lands, allowance untouched, nothing settles). Route crypto publish + settlement through `SETTLEMENT_FEE_TYPE_NAME` (now 'USDT' = slot 4), which resolves to the USDC token on-chain, so approve + mintTicket succeed. Publish sets the fee under the same slot, keeping getAllFees/feeEnabled consistent. TEMPORARY: revert `SETTLEMENT_FEE_TYPE_NAME` to 'USDC' once the Diamond is redeployed with USDC (5) mapped to the USDC address. Requires re-publishing events (existing ones have the fee under slot 5). Tracked in #96.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deployed Base Sepolia Diamond has the real USDC token registered under the USDT (4) FeeType slot; USDC (5) is unset, so mintTicket(…, USDC, …) reverts TokenAddressZero() and Circle never submits the mint (approve lands, allowance untouched, nothing settles).
Route crypto publish + settlement through
SETTLEMENT_FEE_TYPE_NAME(now 'USDT' = slot 4), which resolves to the USDC token on-chain, so approve + mintTicket succeed. Publish sets the fee under the same slot, keeping getAllFees/feeEnabled consistent.TEMPORARY: revert
SETTLEMENT_FEE_TYPE_NAMEto 'USDC' once the Diamond is redeployed with USDC (5) mapped to the USDC address. Requires re-publishing events (existing ones have the fee under slot 5). Tracked in #96.