feat(organizer): update bank details (#47) - #95
Merged
Conversation
Add PUT /api/organizer/bank-details (ORGANIZER). Re-verifies the account via Paystack (account name taken from the resolve, never the client), looks up the bank display name, and persists onto OrganizerProfile with bankVerified=true. Blocked with 400 while a payout is PROCESSING; 403 for non-organizers; account number masked in the response (012****789). - New PaystackService.getBankName(code): cached, best-effort bank-list lookup (returns null on failure so the verified account still saves). - Reuses verifyBankAccount so the dev SKIP_BANK_VERIFICATION bypass works. NOTE: under split settlement the live settlement bank lives on the provider subaccount; propagating this change to the Paystack/Monnify subaccount is a deliberate follow-up, not handled here. 5 tests cover the happy path (mask + Paystack-sourced name), the PROCESSING-payout block, non-organizer 403, and bank-name fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PUT /api/organizer/bank-details (ORGANIZER). Re-verifies the account via Paystack (account name taken from the resolve, never the client), looks up the bank display name, and persists onto OrganizerProfile with bankVerified=true. Blocked with 400 while a payout is PROCESSING; 403 for non-organizers; account number masked in the response (012****789).
NOTE: under split settlement the live settlement bank lives on the provider subaccount; propagating this change to the Paystack/Monnify subaccount is a deliberate follow-up, not handled here.
5 tests cover the happy path (mask + Paystack-sourced name), the PROCESSING-payout block, non-organizer 403, and bank-name fallback.
closes #47