Skip to content

ci: approve the held runs instead of dispatching CI - #7

Merged
hotdogee merged 1 commit into
mainfrom
ci/notices-approve-runs
Oct 30, 2026
Merged

hotdogee merged 1 commit into
mainfrom
ci/notices-approve-runs

Conversation

@hotdogee

Copy link
Copy Markdown
Owner

Follow-up to #5. Testing that workflow on a throwaway pull request showed that checks from a workflow_dispatch run don't appear on the pull request, which stayed at "no checks reported" and UNSTABLE.

A push made with GITHUB_TOKEN creates pull_request runs that wait for approval. The workflow now approves those instead, so CI runs as usual and its checks show on the pull request.

Tested end to end on #6 with this branch's workflow: the stale file was regenerated, both waiting runs were approved with the workflow's own token, CI passed all four jobs, and the pull request reached CLEAN.

The script also stops on any failed git or gh command now, so a rejected push can't pass unnoticed.

🤖 Generated with Claude Code

Checks from a workflow_dispatch run do not show on the pull request, which
stayed at no checks and UNSTABLE. Approving the pull_request runs GitHub
holds after a GITHUB_TOKEN push makes CI run as usual.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@hotdogee
hotdogee merged commit dcd470a into main Oct 30, 2026
6 checks passed
@hotdogee
hotdogee deleted the ci/notices-approve-runs branch October 30, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant