Repository navigation
Restore the bitcoin-logic comments the punctuation pass swept up - #15
Merged
Merged
Conversation
The previous pass applied the punctuation rules to every source file, which pulled in eleven pre-existing bitcoin-logic files that had nothing to do with the Lightning work. Those comments are restored exactly as they were. The single exception is the Bech32Options block, which I wrote this session when BOLT #11 invoices needed the 90-character address ceiling lifted. That one is mine, so the rules apply to it, and it now uses brackets instead of a pair of dashes. The rules govern what I write. They are not a reason to churn code that was already here. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous pass applied the punctuation rules to every source file, which pulled in eleven pre-existing
bitcoin-logicfiles that had nothing to do with the Lightning work. Those comments are restored exactly as they were.The single exception is the
Bech32Optionsblock, which I wrote this session when BOLT #11 invoices needed the 90-character address ceiling lifted. That one is mine, so the rules apply to it, and it now uses brackets instead of a pair of dashes.The diff against the pre-punctuation state is that one comment and nothing else.
The rules govern what I write. They aren't a reason to churn code that was already here, and I've noted that boundary alongside the rules themselves.
147 tests green; lint, build, typecheck clean.
🤖 Generated with Claude Code