Repository navigation
Bump js-yaml from 4.3.0 to 4.3.1 - #4
Closed
dependabot[bot] wants to merge 1 commit into
Closed
dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.3.0 to 4.3.1. - [Changelog](https://github.com/nodeca/js-yaml/blob/4.3.1/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.3.0...4.3.1) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 4.3.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
hotpixelgroup
added a commit
that referenced
this pull request
Aug 26, 2026
Quest #4 showed a payment crossing hops without ever saying where the route came from or who decided what it cost. Routing read as magic and fees were a passing clause. Quest #6 fills it, in four stops that separate the two questions people actually conflate. How a fee is SET: each node picks two numbers per direction — fee_base_msat and fee_proportional_millionths — and gossips them. Nobody approves them, there is no schedule and no floor. How a fee is ASSESSED: one formula fixed by the specification, applied to those numbers, charged on the amount forwarded, paid entirely by the sender in advance so the payee always receives the invoice amount. BOLT #7 is unusually generous here: it works its own example through a four-node network and prints the answer, so the finale reproduces the specification's own sum and refuses to claim anything unless it matches to the millisatoshi. Writing that turned up a real bug. My first implementation charged each hop using the channel the payment ARRIVED on. The spec settles it in the worked example — A pays B the fee B specified on B->C, the channel it forwards OUT of — and the arithmetic came out at 5,099 instead of 10,199. Testing against a primary source caught what testing against myself never would have. A consequence worth stating: the first channel of any route is free, because the node forwarding out of it is the sender. Also: six glossary entries for the fee and gossip vocabulary, a fee calculator and a route race figure, and Quest #4 now points forward rather than leaving the clause hanging. whose-lightning renumbers to #7 so routing sits inside the Routing track. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
hotpixelgroup
added a commit
that referenced
this pull request
Aug 26, 2026
Four questions came in that the routing quest left implicit or unanswered: who receives the fees, does each hop add one, how do you know how many hops there will be, and does it matter. Three of them had no answer anywhere. A new stop takes all four in order, and the most interesting is the first: a routing node is never *sent* anything. It is offered slightly more on the channel a payment arrives on than it offers on the channel it forwards to, and when the preimage settles both HTLCs the difference simply stays on its side. Routing income is a gap between two numbers, not a transfer — which is why it arrives as channel balance and never as an on-chain payment. The hop-count answer has a pleasing asymmetry worth drawing out. The sender knows exactly, because the sender picks the route and builds the onion around it, so the total is settled before anything moves and there is no such thing as a surprise charge. Nobody on the route knows, because Quest #5's whole point is that a hop cannot learn the route's length or its own position. Both are true at once. Does it matter: less than people expect. A long cheap route beats a short expensive one and the wallet will take it; what matters is the total, and you see the total first. There is a ceiling of 20 hops, forced by the onion being a fixed 1,300 bytes, quoted from BOLT #4. All five questions are also in the question-first index, deep-linked to the stop that answers them, and the route finder now names who keeps each fee rather than just showing an amount. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Author
|
Superseded by #19. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps js-yaml from 4.3.0 to 4.3.1.
Changelog
Sourced from js-yaml's changelog.
Commits
86e91b84.3.1 releasedc3cc4b0Backport quadratic complexity fix for !!omapDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.