Skip to content

Fixes all Four #65 #66 #67 #68#69

Merged
houfu merged 8 commits into
houfu:mainfrom
abbasabro:abbas
Oct 14, 2025
Merged

Fixes all Four #65 #66 #67 #68#69
houfu merged 8 commits into
houfu:mainfrom
abbasabro:abbas

Conversation

@abbasabro
Copy link
Copy Markdown
Contributor

@abbasabro abbasabro commented Oct 11, 2025

FIX all Four #65 #66 #67 #68

@houfu
Copy link
Copy Markdown
Owner

houfu commented Oct 12, 2025

Regarding #67, I know that this is what my issue comment said, but I don't like the idea of having a redirecting page with a version number. It's probably better to modify pdoc's template (footer?) to include a reference to the version number. Do you want to try it? If you don't want to, let me clean this PR up a bit and work on the template myself.

@abbasabro abbasabro changed the title Fixes ##65 Fixes all Four #65 #66 #67 #68 Oct 12, 2025
@abbasabro
Copy link
Copy Markdown
Contributor Author

Thanks for the feedback! That makes sense — modifying the pdoc template directly sounds cleaner than adding a redirect.
I’ll update the PR to include the version reference directly in the template (probably in the footer or top banner).
Could you confirm if you’d prefer it in the footer or as a small banner at the top? Once confirmed, I’ll implement and push the changes.

@abbasabro
Copy link
Copy Markdown
Contributor Author

@houfu You can clean the PR yourself not happening with me

@houfu
Copy link
Copy Markdown
Owner

houfu commented Oct 12, 2025

Let's do it in the footer. Looking forward to it!

Comment thread .github/workflows/docs.yml Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md
@houfu houfu merged commit 44e0d1d into houfu:main Oct 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants