Skip to content

Fix: Update the listing accessibility based filtering logic - #1007

Closed
matzduniuk wants to merge 1 commit into
mainfrom
4885/update-listing-a11y-filtering-logic
Closed

Fix: Update the listing accessibility based filtering logic #1007
matzduniuk wants to merge 1 commit into
mainfrom
4885/update-listing-a11y-filtering-logic

Conversation

@matzduniuk

Copy link
Copy Markdown
Collaborator

This PR addresses bloom-housing#4885

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Updates the query formatting logic for the listings endpoint to use the AND logic instead of OR

How Can This Be Tested/Reviewed?

  • Go to the partner's site and update the listings for the setup jurisdiction in a way that allows for accessibility features overlapping (Example below)
Screenshot 2025-08-27 at 14 12 33 * Go to the public sites `/listings` page * Open the `Filters` drawer * Verify that the `Accessibility features` section options follow the AND logic

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

…using#5314)

* chore: update the listing feature query formatting to use AND logic
* chore: update integration tests
* test: re-run netflify deploy
@netlify

netlify Bot commented Aug 29, 2025

Copy link
Copy Markdown

Deploy Preview for housing-sanjoseca-gov ready!

Name Link
🔨 Latest commit 4f4a880
🔍 Latest deploy log https://app.netlify.com/projects/housing-sanjoseca-gov/deploys/68b16a2f2aae000008bc3bd7
😎 Deploy Preview https://deploy-preview-1007--housing-sanjoseca-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@matzduniuk
matzduniuk marked this pull request as ready for review August 29, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants