[TEST ONLY] Revert Runner/HasSharedConsole and ManagesTasks to isolate hang - #31
Closed
devin-ai-integration[bot] wants to merge 11 commits into
Closed
[TEST ONLY] Revert Runner/HasSharedConsole and ManagesTasks to isolate hang#31devin-ai-integration[bot] wants to merge 11 commits into
devin-ai-integration[bot] wants to merge 11 commits into
Conversation
- Add ParallelWorker::write() and ParallelWorker::writeln() methods. - Route messages through ProgressBarWorker when a progress bar is active (clear/write/display). - Add a ConsoleWorker fallback for workers without a progress bar. - Use a shared stderr OutputInterface so ProgressBar and messages share the same stream. - Add WriteOutputMessage command and ConsoleWorker/HasChannels infrastructure. - Update README and CHANGELOG. Co-Authored-By: Hermann D. Schimpf <hschimpf@hds-solutions.net>
Co-Authored-By: Hermann D. Schimpf <hschimpf@hds-solutions.net>
Co-Authored-By: Hermann D. Schimpf <hschimpf@hds-solutions.net>
Co-Authored-By: Hermann D. Schimpf <hschimpf@hds-solutions.net>
Co-Authored-By: Hermann D. Schimpf <hschimpf@hds-solutions.net>
…to STDERR Co-Authored-By: Hermann D. Schimpf <hschimpf@hds-solutions.net>
Co-Authored-By: Hermann D. Schimpf <hschimpf@hds-solutions.net>
Co-Authored-By: Hermann D. Schimpf <hschimpf@hds-solutions.net>
Co-Authored-By: Hermann D. Schimpf <hschimpf@hds-solutions.net>
Co-Authored-By: Hermann D. Schimpf <hschimpf@hds-solutions.net>
Co-Authored-By: Hermann D. Schimpf <hschimpf@hds-solutions.net>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway test to see if the CI hang is caused by the Runner-side
HasSharedConsole/console-connection wiring.Summary
src/Internals/Runner.phpto not useHasSharedConsole.src/Internals/Runner/ManagesTasks.phpto itsmainstate.CommunicatesWithProgressBarWorkertrait additions andProgressBarWorker::writeOutput()from PR Add worker console messages (write/writeln) alongside ProgressBar #28.If CI passes, the regression is in the Runner/ManagesTasks changes. If it still hangs, the regression is elsewhere (likely trait/ProgressBarWorker additions).
Link to Devin session: https://app.devin.ai/sessions/aa44109acb6346c2abd6b14c45072be7
Requested by: @hschimpf