Repository navigation
fix(digest): drop per-user rankings and lock English output with an e2e test - #7
Closed
hsuchifeng wants to merge 1 commit into
Closed
hsuchifeng wants to merge 1 commit into
hsuchifeng wants to merge 1 commit into
Conversation
…2e test The digest prints team-wide totals only; the unused per-user `ranked` arrays in summarizeInterventions / summarizeConversation are removed so no caller can bring individual rankings back. A real-CLI e2e test asserts the digest is all English and names no member; usage-guide docs updated. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R5AmspzzVhLVupACwm4W3e
Code Erosion ReportInformational — never blocks the merge.
Scanned 304 files / 60608 SLOC · high-CC functions 420/4834 * On TypeScript, Rule hits (TS verbosity layer)Standalone
38 distinct lines flagged across |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #3 (digest output in English, no per-user intervention / token rankings). The printed digest on
mainis already English and no longer prints the ranking lines, butsummarizeInterventions/summarizeConversationstill computed and returned per-userrankedarrays that nothing used. This PR:rankedfields so individual rankings cannot quietly come back through the summary API;src/__tests__/digest-output-e2e.test.ts): agitprovider team with two members' reported stats onteamai-reports, thenteamai digestmust contain no CJK characters, print the English autonomy / token sections with team-wide totals, and never print a member name or the word "rank";docs/usage-guide.md/docs/usage-guide.zh-CN.md, which still described per-person rankings.Type of Change
Test Plan
npx tsc --noEmitpassesnpm run lintpassesnpx vitest runpasses (full unit suite)npm run build && npx vitest run --config vitest.e2e.config.ts src/__tests__/digest-output-e2e.test.ts src/__tests__/intervention-e2e.test.ts src/__tests__/conversation-token-e2e.test.ts→ 7/7 passed. Sample output from the run:digest-output-e2e.test.ts;digest-interventions,conversation-token-metrics,conversation-token-e2e,intervention-e2eno longer assert onrankedRelated Issues
Covers the scenario from #3.
Notes for Reviewers
rankedwas only read by tests; the summary interfaces lose that field. Theteamai.yamlwording inskill-data/does not mention rankings, so only the usage guides needed a docs update.Generated by Claude Code