первый пулл реквест #1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,275 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <link rel="stylesheet" href="#"> | ||
| <title>Document</title> | ||
| </head> | ||
| <body> | ||
| <header class="page-header"> | ||
| <a class="logo-link" href="#"> | ||
| <img class="logo" src="images/header/logo.svg" width="140" height="70" alt="Логотип"> | ||
| </a> | ||
| <nav class="navigation"> | ||
| <ul class="navigation-list"> | ||
| <li class="navigation-item"> | ||
| <a class="navigation-link" href="#">Главная</a> | ||
| </li> | ||
| <li class="navigation-item"> | ||
| <a class="navigation-link" href="#">О Седоне</a> | ||
| </li> | ||
| <li class="navigation-item"> | ||
| <a class="navigation-link" href="#">Гостиницы</a> | ||
| </li> | ||
| </ul> | ||
| <ul class="navigation-list navigation-user"> | ||
| <li class="navigation-item"> | ||
| <a class="navigation-link" href="#"> | ||
| <span class="visually-hidden">Поиск по сайту</span> | ||
| </a> | ||
| </li> | ||
| <li class="navigation-item"> | ||
| <a class="user-link" href=""> | ||
| <a class="navigation-link" href="#"> | ||
| <span class="visually-hidden">Избранное</span> | ||
| <span class="favorite">12</span> | ||
| </a> | ||
| </li> | ||
| <li class="navigation-item"> | ||
| <a class="navigation-link" href="#">Хочу сюда!</a> | ||
| </li> | ||
| </ul> | ||
| </nav> | ||
| </header> | ||
| <main> | ||
| <section class="catalog"> | ||
| <h1 class="catalog-title">Гостиницы Седоны</h1> | ||
| <ul class="catalog-navigation"> | ||
| <li class="catalog-navigation-item"> | ||
| <a class="catalog-navigation-link" href="index.html"> | ||
| <span class="visually-hidden">Главная</span> | ||
| </a> | ||
| </li> | ||
| <li class="catalog-navigation-item"> | ||
| <a class="catalog-navigation-link" href="#">Гостиницы</a> | ||
| </li> | ||
| </ul> | ||
| <form class="catalog-filter" action="#" method="get"> | ||
|
There was a problem hiding this comment. Лучшие задать форме action, который указан в задании? чтобы можно было проверить, какие данные уходят на сервер |
||
| <fieldset class="catalog-filter-chexkbox"> | ||
| <legend class="catalog-filter-title">Инфраструктура</legend> | ||
| <ul class="catalog-filter-list"> | ||
| <li class="catalog-filter-item"> | ||
| <label class="catalog-checked"> | ||
| <input class="filet-input" type="checkbox" name="pool" checked> | ||
| <span class="filet-label">Бaccейн</span> | ||
| </label> | ||
| </li> | ||
| <li class="catalog-filter-item"> | ||
| <label class="catalog-checked"> | ||
| <input class="filet-input" type="checkbox" name="parking" checked> | ||
| <span class="filet-label">Парковка</span> | ||
| </label> | ||
| </li> | ||
| <li class="catalog-filter-item"> | ||
| <label class="catalog-checked"> | ||
| <input class="filet-input" type="checkbox" name="Wi-Fi" checked> | ||
| <span class="filet-label">Wi-Fi</span> | ||
| </label> | ||
| </li> | ||
| </ul> | ||
| </fieldset> | ||
| <fieldset> | ||
| <legend class="catalog-filter-title">Тип жилья:</legend> | ||
| <ul class="catalog-filter-list"> | ||
| <li class="catalog-filter-item"> | ||
| <label class="catalog-radio"> | ||
| <input class="filet-input" name="type-housing" type="radio" checked value="Hotel"> | ||
| <span class="filet-label">Гостиница</span> | ||
| </label> | ||
| </li> | ||
| <li class="catalog-filter-item"> | ||
| <label class="catalog-radio"> | ||
| <input class="filet-input" name="type-housing" type="radio" checked value="Motel"> | ||
| <span class="filet-label">Мотель</span> | ||
| </label> | ||
| </li> | ||
| <li class="catalog-filter-item"> | ||
| <label class="catalog-radio"> | ||
| <input class="filet-input" name="type-housing" type="radio" checked value="Apartment"> | ||
| <span class="filet-label">Апартаменты</span> | ||
| </label> | ||
| </li> | ||
| </ul> | ||
| </fieldset> | ||
| <fieldset class="catalog-filter-price"> | ||
| <legend class="catalog-filter-title">Стоимость, Р:</legend> | ||
| <div class="catalog-inputs"> | ||
| <input class="catalog-min" type="text" name="min-sum" value="0"> | ||
|
There was a problem hiding this comment. Для полей ввода цены лучше использовать input type="number" |
||
| <input class="catalog-max" type="text" name="max-sum" value="9000"> | ||
| <span class="from-to">от</span> | ||
| <span class="before-to">до</span> | ||
| </div> | ||
| <div class="range-scale"> | ||
| <div class="range-bar"> | ||
| <button class="range-toggle toggle-min" type="button"> | ||
| <span class="visually-hidden">Изменить минимальную цену</span> | ||
| </button> | ||
| <button class="range-toggle toggle-max" type="button"> | ||
| <span class="visually-hidden">Изменить максимальную цену</span> | ||
| </button> | ||
| </div> | ||
| </div> | ||
| </fieldset> | ||
| <div class="catalog-buttons"> | ||
| <button class="catalog-submit" type="submit">Применить</button> | ||
| <button class="catalog-reset" type="reset">Сбросить</button> | ||
| </div> | ||
| </form> | ||
| </section> | ||
| <div class="search"> | ||
| <p class="found-hotel">Найдено гостиниц: | ||
| <span class="found-hotel">38</span> | ||
| </p> | ||
| <select class="select-control"> | ||
| <option value="">Сначала дешевые</option> | ||
|
There was a problem hiding this comment. value в теге option не должно быть пустым |
||
| </select> | ||
| <ul class="display-list"> | ||
| <li class="display-item"> | ||
| <a class="display-button current-batton" href="catalog.html?view=tile"> | ||
| <span class="visually-hidden">Показать таблицей</span> | ||
| </a> | ||
| </li> | ||
| <li class="display-item"> | ||
| <a class="display-button view-item" href="catalog.html?view=card"> | ||
| <span class="visually-hidden">Показать по одной карточке</span> | ||
| </a> | ||
| </li> | ||
| <li class="display-item"> | ||
| <a class="display-button view-item" href="catalog.html?view=list"> | ||
| <span class="visually-hidden">Показать списком</span> | ||
| </a> | ||
| </li> | ||
| </ul> | ||
| </div> | ||
| <ul class="product-list"> | ||
| <li class="product-item"> | ||
| <img class="product-img" src="images/catalog/Amara-Resort-Spa.jpg" width="300" height="212" alt="гостиница Amara Resort & Spa"> | ||
|
There was a problem hiding this comment. В карточке гостиницы ссылкой для перехода на саму гостиницу должны также быть изображение и заголовок |
||
| <div class="card-container"> | ||
| <h3 class="product-title">Amara Resort & Spa</h3> | ||
| <p class="type">Гостиница</p> | ||
| <p class="product-price">От 4000 ₽</p> | ||
| <a class="product-link-details" href="#">Подробнее</a> | ||
| <button class="product-button" type="button">В избранное</button> | ||
| <p class="catalog-hotel-stars"> | ||
| <span class="visually-hidden">4 звезды</span> | ||
| </p> | ||
| <p class="catalog-hotel-raiting">Рейтинг: 8,5</p> | ||
| </div> | ||
| </li> | ||
| <li class="product-item"> | ||
| <img class="product-img" src="images/catalog/Villas-at-Poco-Diablo.jpg" width="300" height="212" alt="гостиница Villas at Poco Diablo"> | ||
| <div class="card-container"> | ||
| <h3 class="product-title">Villas at Poco Diablo</h3> | ||
| <p class="type">Гостиница</p> | ||
| <p class="product-price">От 5000 ₽</p> | ||
| <a class="product-link-details" href="#">Подробнее</a> | ||
| <button class="product-button" type="button">В избранное</button> | ||
| <p class="catalog-hotel-stars"> | ||
| <span class="visually-hidden">4 звезды</span> | ||
| </p> | ||
| <p class="catalog-hotel-raiting">Рейтинг: 9,2</p> | ||
| </div> | ||
| </li> | ||
| <li class="product-item"> | ||
| <img class="product-img" src="images/catalog/Desert-Quail-Inn.jpg" width="300" height="212" alt="гостиница Desert Quail Inn"> | ||
| <div class="card-container"> | ||
| <h3 class="product-title">Desert Quail Inn</h3> | ||
| <p class="type">Гостиница</p> | ||
| <p class="product-price">От 2500 ₽</p> | ||
| <a class="product-link-details" href="#">Подробнее</a> | ||
| <button class="product-button" type="button">В избранное</button> | ||
| <p class="catalog-hotel-stars"> | ||
| <span class="visually-hidden">3 звезды</span> | ||
| </p> | ||
| <p class="catalog-hotel-raiting">Рейтинг: 6,9</p> | ||
| </div> | ||
| </li> | ||
| <li class="product-item"> | ||
| <img class="product-img" src="images/catalog/GreenTree-Inn.jpg" width="300" height="212" alt="гостиница GreenTree Inn"> | ||
| <div class="card-container"> | ||
| <h3 class="product-title">Amara Resort & Spa</h3> | ||
| <p class="type">Гостиница</p> | ||
| <p class="product-price">От 1500 ₽</p> | ||
| <a class="product-link-details" href="#">Подробнее</a> | ||
| <button class="product-button" type="button">В избранное</button> | ||
| <p class="catalog-hotel-stars"> | ||
| <span class="visually-hidden">2 звезды</span> | ||
| </p> | ||
| <p class="catalog-hotel-raiting">Рейтинг: 5,0</p> | ||
| </div> | ||
| </li> | ||
| </ul> | ||
| <ul class="pagination"> | ||
| <li class="pagination-item"> | ||
| <a class="pagination-link-current">1</a> | ||
| </li> | ||
| <li class="pagination-item"> | ||
| <a class="pagination-link" href="#">2</a> | ||
| </li> | ||
| <li class="pagination-item"> | ||
| <a class="pagination-link" href="#">3</a> | ||
| </li> | ||
| <li class="pagination-item"> | ||
| <a class="pagination-link" href="#">4</a> | ||
| </li> | ||
| <li class="pagination-item"> | ||
| <a class="pagination-link" href="#">. . .</a> | ||
|
There was a problem hiding this comment. Убираем href у ссылки, т.к. троеточие является декоративным элементом |
||
| </li> | ||
| <li class="pagination-item"> | ||
| <a class="pagination-link" href="#">10</a> | ||
| </li> | ||
| </ul> | ||
| </main> | ||
| <footer class="footer"> | ||
| <section> | ||
| <h2>Подпишитесь на рассылку</h2> | ||
| <p>Только полезная информация и накого спама, честное бойскаутское!</p> | ||
| <form class="newsletter-form" action="https://echo.htmlacademy.ru/" method="post"> | ||
| <input class="field" placeholder="Ваш e-mail" type="email" name="email" required> | ||
| <button class="button newsletter-button" type="submit"> | ||
| <span class="visually-hidden">Отправить</span> | ||
| </button> | ||
| </form> | ||
| </section> | ||
| <div class="footer-social"> | ||
| <ul class="footer-social-list"> | ||
| <li class="footer-social-item"> | ||
| <a class="button" href="https://vk.com/htmlacademy"> | ||
| <span class="visually-hidden">ВКонтакте</span> | ||
| </a> | ||
| </li> | ||
| <li class="footer-social-item"> | ||
| <a class="button" href="https://t.me/htmlacademy"> | ||
| <span class="visually-hidden">Телеграмм</span> | ||
| </a> | ||
| </li> | ||
| <li class="footer-social-item"> | ||
| <a class="button" href="https://www.youtube.com/user/htmlacademyru"> | ||
| <span class="visually-hidden">Ютуб</span> | ||
| </a> | ||
| </li> | ||
| </ul> | ||
| </div> | ||
| <div class="footer-contacts"> | ||
| <h2 class="visually-hidden">Номер телефона</h2> | ||
| <a class="footer-phone-link" href="tel:+78128121212">+7 (812) 812-12-12</a> | ||
| </div> | ||
| <div class="footer-logo"> | ||
| <a class="footer-logo-link" href="https://htmlacademy.ru/intensive/htmlcss"> | ||
| <img class="footer-logo-image" src="#" alt="Логотип HTML Академии"> | ||
| </a> | ||
| </div> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
.svg){kind=link}
|
There was a problem hiding this comment. У всех иконок должно быть соответствуещее им название |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
|
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Задать корреткные ссылки в атрибуте href всех элементов навигации