removed breaked author comment name - #76
Open
CaiqueCoelho wants to merge 2 commits into
Open
Conversation
Author
|
Hi @huaying can you check this PR please? 💃 |
Owner
|
Sorry I am not maintaining this repo. If this is just a temporarily fix, please feel free to fork this repo and work on it, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today this piece of code is broken:
author = browser.find_one(".FPmhX", els_comment).text
AttributeError: 'NoneType' object has no attribute 'text'
#75
Maybe the class with the author name from a comment has changed and any comment is geted once the code break before taking the comment and saving.
This solution is not the best, once I remove the author name, the code stop breaking and therefore the code keeps taking comments and saving. Perhaps this could be a solution at the moment and in the future we can get back to the author's name