feat: add infallible first-last accessor methods#7
Merged
Conversation
- provide `first()`, `last()`, `split_first()`, `split_last()` methods. - use unsafe blocks for performance, and throughly document the safety. - add tests and miri workflow to ci.
There was a problem hiding this comment.
Pull Request Overview
This PR adds infallible accessor methods to the NonEmptyBz type for retrieving first and last bytes, along with splitting operations. The implementation leverages the non-empty guarantee to use unsafe optimizations while maintaining safety through thorough documentation and Miri testing.
- Implements
first(),last(),split_first(), andsplit_last()methods with unsafe optimizations - Adds comprehensive test coverage using rstest parameterized tests
- Introduces Miri CI workflow for undefined behavior detection
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib.rs | Implements the four new accessor methods with unsafe blocks and comprehensive test suite |
| README.md | Documents the safety notice and Miri verification process |
| Cargo.toml | Version bump and adds rstest dev dependency |
| .github/workflows/miri.yml | New CI workflow for Miri undefined behavior testing |
hubcycle
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first(),last(),split_first(),split_last()methods.