Issue #166: Remove continue-on-error from simulation CI job#176
Merged
hubertciebiada merged 1 commit intoApr 19, 2026
Merged
Conversation
Make the Simulation tests CI job a hard gate for merges to master so scenario regressions block the release instead of being silently ignored. Also document the three pytest markers (unit, simulation, slow) and how to skip the slow tier locally in README's Running Tests section, including an explicit note that the Simulation tests job now blocks merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #166
Summary
continue-on-error: truefrom thesimulation-testsjob in.github/workflows/ci.ymlso simulation regressions now hard-block merges tomaster.unit/simulation/slowpytest markers in the README "Running Tests" section and show how to skip the slow tier locally (-m "simulation and not slow").Simulation testsCI job is a hard gate.Verification
grep -r "continue-on-error" .github/→ no matchespytest tests/simulation/ -m simulation --tb=long→ 88 passed in 55s locallyruff check+ruff format --checkclean