-
Notifications
You must be signed in to change notification settings - Fork 0
Add ability to have certain meetings put you into DND with set command
#108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esponse for a user" This reverts commit ce663f7.
…ng to make getting the status easier later
james-vaughn
approved these changes
Sep 16, 2025
Contributor
james-vaughn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the wiki with the dnd stuff as well?
https://github.com/hudl/CalendarToSlack/wiki
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
@Foshkey has a feature request for the ability to have certain meetings (like squad health checks or retros) automatically put the user into DND. This feature will default to false and only take effect if the user explicitly sets it to true.
Implementation plan
Add the scope to allow for
dnd:writeto the app. DONEAdd an additional param to set called "dnd" with a true/false variable that is not required and defaults to
false. Will need to update the wiki after this change. Can add the arg here and havehandleSetread the arg. Will probably store the arg in an optional entry in StatusMapping calleddndthat is a boolean. (can't use snooze verbage since it is already in use in the app with settings snoozed=true) DONE REFACTORUse the dnd.info API to get if the user has a snooze that is longer than the duration of the meeting they have DND on for (don't want to override when someone is on holiday for example). Could be slid in here as aREVERT The dnd.setSnooze API already handles this case so this is no longer needed!getUserDndInfo()function. DONEUse the dnd.setSnooze API to set the snooze to the
num_minutesthat the meeting is. Could be slid in here as well as asetUserDnd()function. DONE REFACTOR FIXAdd the logic to anywhere in the code whereEasier and cleaner to just callsetUserStatus()issetUserDnd()fromsetUserStatus(). DONEUpdate the output in handleShow to show if a meeting will turn on DND or not DONE
Write tests DONE
Update the wiki (After PR is merged) DONE