Skip to content

Conversation

@blaine-traudt-hudl
Copy link
Contributor

@blaine-traudt-hudl blaine-traudt-hudl commented Aug 13, 2025

Overview

@Foshkey has a feature request for the ability to have certain meetings (like squad health checks or retros) automatically put the user into DND. This feature will default to false and only take effect if the user explicitly sets it to true.

Implementation plan

  1. Add the scope to allow for dnd:write to the app. DONE

  2. Add an additional param to set called "dnd" with a true/false variable that is not required and defaults to false . Will need to update the wiki after this change. Can add the arg here and have handleSet read the arg. Will probably store the arg in an optional entry in StatusMapping called dnd that is a boolean. (can't use snooze verbage since it is already in use in the app with settings snoozed=true) DONE REFACTOR

  3. Use the dnd.info API to get if the user has a snooze that is longer than the duration of the meeting they have DND on for (don't want to override when someone is on holiday for example). Could be slid in here as a getUserDndInfo() function. DONE REVERT The dnd.setSnooze API already handles this case so this is no longer needed!

  4. Use the dnd.setSnooze API to set the snooze to the num_minutes that the meeting is. Could be slid in here as well as a setUserDnd() function. DONE REFACTOR FIX

  5. Add the logic to anywhere in the code where setUserStatus() is Easier and cleaner to just call setUserDnd() from setUserStatus(). DONE

  6. Update the output in handleShow to show if a meeting will turn on DND or not DONE

  7. Write tests DONE

  8. Update the wiki (After PR is merged) DONE

@blaine-traudt-hudl blaine-traudt-hudl self-assigned this Aug 13, 2025
@blaine-traudt-hudl blaine-traudt-hudl added the enhancement New feature or request label Aug 13, 2025
@blaine-traudt-hudl blaine-traudt-hudl marked this pull request as ready for review September 16, 2025 15:39
Copy link
Contributor

@james-vaughn james-vaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the wiki with the dnd stuff as well?
https://github.com/hudl/CalendarToSlack/wiki

@blaine-traudt-hudl blaine-traudt-hudl merged commit 07ab17a into master Sep 16, 2025
3 checks passed
@blaine-traudt-hudl blaine-traudt-hudl deleted the SupportDndForCertainMeetings branch September 16, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants