fix(ci): no-op Version Packages workflow when no changesets exist - #2
Merged
Conversation
The v2 split version action runs 'changeset version' unconditionally and fails with exit code 1 when main has no pending changesets. Use the combined changesets/action@v2 without a publish script instead, which exits cleanly with an informational message in that case, and correct the invalid 'title' input to 'pr-title'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
changesets/action/version@v2runschangeset versionunconditionally and exits 1 with "No unreleased changesets found" whenmainhas no pending changesets. It is designed to run only afterselect-modereturnsversion.changesets/action@v2without a publish script, which exits cleanly with an informational message when there are no changesets and creates/updates the Version Packages PR when there are. Also correct the invalidtitleinput topr-title(it was silently ignored with a warning).Reason
The workflow was expected to be a no-op for changeset-free merges such as #1, but the split action lacks that guard when used standalone.
Test notes
main(this merge itself should complete as a clean no-op).