Make all generated members nonisolated#26
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for @MainActor isolation to the @Generable macro by marking all generated protocol requirement implementations as nonisolated. This allows types annotated with both @MainActor and @Generable to work correctly without actor isolation conflicts.
Key changes:
- Added
nonisolatedkeyword to all generated methods and properties in the@Generablemacro - Added a test case to verify
@MainActorisolated structs work with the@Generablemacro - Minor code style improvements (removing extra blank lines, simplifying syntax initializers)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Sources/AnyLanguageModelMacros/GenerableMacro.swift | Added nonisolated keyword to all generated protocol implementations (init, properties, and methods) to support @MainActor isolation; minor syntax and formatting improvements |
| Tests/AnyLanguageModelTests/GenerableMacroTests.swift | Added test case with @MainActor isolated struct to verify the macro works correctly with actor isolation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #24
This PR fixes
MainActorisolation compilation issues by updating the@Generablemacro declarations to benonisolated.