Refactor cross-cutting stable-memory and VFS plumbing - #10
Draft
humandebri wants to merge 29 commits into
Draft
Conversation
Gate storage_stats behind canister-api and clear_superblock_cache behind cfg(test); both lost their unconditional callers in the phase-3 layering commits. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
cargo fmt --all --checkgit diff --checkrg -nUP '[\x{061C}\x{200E}\x{200F}\x{202A}-\x{202E}\x{2066}-\x{2069}]' .(no matches)cargo check --no-default-features --features sqlite-bundledcargo check --features canister-apicargo check --features bench-profilecargo check --target wasm32-unknown-unknown --no-default-features --features sqlite-precompiledcargo check --target wasm32-unknown-unknown --no-default-features --features sqlite-precompiled,canister-apicargo testVERUS_REQUIRED=1 bash scripts/sqlite-critical-check.shCI failure notes:
VERUS_REQUIRED=1 bash scripts/sqlite-critical-check.shrun first stopped becausedocs/PUBLIC_API_2_0.snapshotwas stale after movingsrc/db/connection.rstosrc/db/connection/mod.rs.candid/ic-cdkoptional; those lock snapshots are now refreshed.Invalid matrix commands for the current feature design:
cargo check --no-default-featuresintentionally fails because no SQLite backend is selected.cargo check --no-default-features --features sqlite-precompiledis only valid forwasm32-unknown-unknown; native targets intentionally fail.cargo test --all-featuresintentionally enables bothsqlite-bundledandsqlite-precompiled, which are mutually exclusive.