Skip to content

api: evaluating the query's data type requires access to the dataset #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aybabtme merged 2 commits into from
Aug 29, 2025
Merged

api: evaluating the query's data type requires access to the dataset #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72e3aa9
api: evaluating the query's data type requires access to the dataset
aybabtme Aug 29, 2025
91005f9
bump deps
aybabtme Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 27 additions & 9 deletions go/svc/query/v1/service.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 14 additions & 2 deletions js/svc/query/v1/service_pb.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,15 @@ export class ParseRequest extends Message<ParseRequest> {
*/
query = "";

/**
* if provided, the query's data type will be evaluated for the environment
* this requires looking up the environment, so the user must be logged in
* and have access to the environment to request this information
*
* @generated from field: optional int64 environment_id = 2;
*/
environmentId?: bigint;

constructor(data?: PartialMessage<ParseRequest>) {
super();
proto3.util.initPartial(data, this);
Expand All @@ -170,6 +179,7 @@ export class ParseRequest extends Message<ParseRequest> {
static readonly typeName = "svc.query.v1.ParseRequest";
static readonly fields: FieldList = proto3.util.newFieldList(() => [
{ no: 1, name: "query", kind: "scalar", T: 9 /* ScalarType.STRING */ },
{ no: 2, name: "environment_id", kind: "scalar", T: 3 /* ScalarType.INT64 */, opt: true },
]);

static fromBinary(bytes: Uint8Array, options?: Partial<BinaryReadOptions>): ParseRequest {
Expand Down Expand Up @@ -199,7 +209,9 @@ export class ParseResponse extends Message<ParseResponse> {
query?: Query;

/**
* @generated from field: types.v1.DataStreamType data_type = 2;
* will be populated if user is logged in and `environment_id` is specified
*
* @generated from field: optional types.v1.DataStreamType data_type = 2;
*/
dataType?: DataStreamType;

Expand All @@ -212,7 +224,7 @@ export class ParseResponse extends Message<ParseResponse> {
static readonly typeName = "svc.query.v1.ParseResponse";
static readonly fields: FieldList = proto3.util.newFieldList(() => [
{ no: 1, name: "query", kind: "message", T: Query },
{ no: 2, name: "data_type", kind: "message", T: DataStreamType },
{ no: 2, name: "data_type", kind: "message", T: DataStreamType, opt: true },
]);

static fromBinary(bytes: Uint8Array, options?: Partial<BinaryReadOptions>): ParseResponse {
Expand Down
64 changes: 32 additions & 32 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"devDependencies": {
"@bufbuild/buf": "^1.56.0",
"@bufbuild/buf": "^1.57.0",
"@bufbuild/protoc-gen-es": "^1.10.1",
"@connectrpc/connect": "^1.6.1",
"@connectrpc/connect-query": "^1.4.2",
Expand Down
7 changes: 6 additions & 1 deletion proto/svc/query/v1/service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,16 @@ message SummarizeEventsResponse {

message ParseRequest {
string query = 1;
// if provided, the query's data type will be evaluated for the environment
// this requires looking up the environment, so the user must be logged in
// and have access to the environment to request this information
optional int64 environment_id = 2;
}

message ParseResponse {
types.v1.Query query = 1;
types.v1.DataStreamType data_type = 2;
// will be populated if user is logged in and `environment_id` is specified
optional types.v1.DataStreamType data_type = 2;
}

message FormatRequest {
Expand Down
Loading