Pass context to the logger class override hook#78
Open
dd32 wants to merge 1 commit intohumanmade:masterfrom
Open
Pass context to the logger class override hook#78dd32 wants to merge 1 commit intohumanmade:masterfrom
dd32 wants to merge 1 commit intohumanmade:masterfrom
Conversation
When extending the Logger class, information about the Database connection is likely to be required by the Logger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When extending the Logger class, information about the Database connection is likely to be required by the Logger.
Prior to #72 7af82ca the following code worked:
Now code similar to this is required:
Alternatively, these could be made public, but just passing it as an extra arg is probably enough..