Skip to content

Prevent full-width menus from causing horizontal scroll - #19

Open
kadamwhite wants to merge 2 commits into
mainfrom
scroll-overflow
Open

kadamwhite wants to merge 2 commits into
mainfrom
scroll-overflow

Conversation

@kadamwhite

Copy link
Copy Markdown
Contributor

100vw does not account for the size of the nav bar, whereas 100% will resolve against the relative positioning context

100vw does not account for the size of the nav bar, whereas 100% will resolve against the relative positioning context
@kadamwhite

Copy link
Copy Markdown
Contributor Author

Doubling up with a bugfix version bump to avoid needing subsequent review

@pamprn09

pamprn09 commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

I'm concerned what this might cause in non FSE sites:

Twenty Twenty-Five main Twenty Twenty-Five branch
shot-1440-main shot-1440-branch

@kadamwhite

Copy link
Copy Markdown
Contributor Author

n.b., twentytwentyfive is an FSE site, but not configured in the same way as our normal uses of this plugin.

Good feedback; it does change behavior, so would be dangerous to ship as a patch regardless. I'd argue the current handling is also wrong on twentytwentyfive because right: -1px on the menu doesn't align it with the right side of the screen, and the 100vw menu therefore goes off-screen to the left.

I would therefore expect this change to be non-impactful anywhere that the current styling displays correctly, but I'm fine making the fix on the level of the project where we use this, for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants