Repository navigation
Prevent full-width menus from causing horizontal scroll - #19
Open
kadamwhite wants to merge 2 commits into
Open
kadamwhite wants to merge 2 commits into
kadamwhite wants to merge 2 commits into
Conversation
100vw does not account for the size of the nav bar, whereas 100% will resolve against the relative positioning context
Contributor
Author
|
Doubling up with a bugfix version bump to avoid needing subsequent review |
Collaborator
Contributor
Author
|
n.b., twentytwentyfive is an FSE site, but not configured in the same way as our normal uses of this plugin. Good feedback; it does change behavior, so would be dangerous to ship as a patch regardless. I'd argue the current handling is also wrong on twentytwentyfive because I would therefore expect this change to be non-impactful anywhere that the current styling displays correctly, but I'm fine making the fix on the level of the project where we use this, for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


100vw does not account for the size of the nav bar, whereas 100% will resolve against the relative positioning context