Taxonomy filter to respect query loop settings #29
+87
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The taxonomy filter pulldown will display all terms from that taxonomy, regardless of whether the parent query loop is using taxonomy filtering or not.
It seems to me that if you're limiting the terms in a query loop, the filter pulldown should be limited to those same terms - otherwise you can select a term that's not in the query loop's result set and get "nothing found."
This branch handles this situation, both for filtering via the standard Gutenberg taxonomy filter and Advance Query Loop's implementation. Note that the latter is only partially supported due to limitations in WP's get_terms function - specifically, only IN and NOT IN operators are supported, and multiple term queries must use the OR relation.