Fix incorrect token offsets for multi-byte Unicode characters - #204
Open
naaish-adam wants to merge 2 commits into
Open
Fix incorrect token offsets for multi-byte Unicode characters#204naaish-adam wants to merge 2 commits into
naaish-adam wants to merge 2 commits into
Conversation
Collaborator
|
Thanks for putting this together. I'd like to keep the behavior between the Rust and JS implementations the same, otherwise the unified tests will fail. Do you want to take a look at that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, slicing strings using token offsets fails for multi-byte Unicode characters like é or ₹ because the tokenizer advances the offset by 1 for all characters regardless of their byte length. This PR fixes it by advancing by byte length (
char.len_utf8()) instead of character length for offset values.Example JSON that produces incorrect offsets: