Repository navigation
Conversation
huntharo
force-pushed
the
fix/rescan-progress-panel
branch
from
September 27, 2026 03:21
d6a9841 to
e77a59c
Compare
huntharo
marked this pull request as draft
September 27, 2026 03:41
huntharo
pushed a commit
that referenced
this pull request
Sep 27, 2026
Restore parallel deletes while retaining progress
huntharo
force-pushed
the
fix/rescan-progress-panel
branch
from
October 14, 2026 16:18
e77a59c to
0bb5dc1
Compare
huntharo
force-pushed
the
fix/rescan-progress-panel
branch
from
October 22, 2026 01:50
0bb5dc1 to
cb94981
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After clicking Rescan, Overview showed only a static-looking icon while the prior scan's index loaded with zero files counted. Its progress bar required a numeric percentage, so it also disappeared during finalization. Once file tiles appeared, the central progress presentation disappeared entirely.
Reuse the existing loading panel throughout the scan, with a compact layout above the treemap once results arrive. Preparation, metadata loading, and finalization show an animated indeterminate indicator without a percentage. Walking and indexing use the same available percentage as the header and drive indicator. Phase text, counts, elapsed time, and the existing Stop button remain available. The panel disappears on completion or cancellation.
The JavaScript worker previously inherited
scanPhase: "starting"for every snapshot. It now explicitly reports walking after baseline loading, finalizing before flushing its output, and complete on completion. This preserves byte-based walking progress and prevents active JS scans from remaining labeled as preparation.Before / after
Matching captures of the base renderer (
27c35dd) and PR renderer (e77a59c) in Electron on macOS at 1280 × 800. Both receive identical injected scan snapshots; file counts, sizes, and elapsed times are fixtures. No full-disk scan was run. Click an image to view it at full size.Validated on macOS:
bun run typecheckand renderer/Electron builds pass. The native build also passed during initial validation.The separate missing-native-scanner fallback and reported out-of-memory failure remain unresolved. No new disk writes or per-file/per-folder traversal are introduced.