Repository navigation
Conversation
huntharo
force-pushed
the
feat/macos-system-metadata
branch
from
October 14, 2026 20:14
854dfd6 to
bc6243a
Compare
huntharo
pushed a commit
that referenced
this pull request
Oct 22, 2026
…ee-lock Show removal results with the approval and serialize worktree removal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS scans can omit substantial storage when
.fseventsdor.Spotlight-V100cannot be read. The scanners already retained these Data-volume stores, but Overview had no named categories or indication that their sizes were unavailable. This change adds Filesystem event history (FSEvents) and Spotlight search index to Overview.Both scanners collect allocated regular-file bytes during the existing walk, independently of the largest-folder display limit. The categories resolve the owning mount through the scan's existing mount/firmlink plan, including mounts outside
/Volumesand nested volumes. Startup stores retain canonical Data-volume paths; other stores use the path through which the scan reads them. Hardlinks remain deduplicated across the scan, and category bytes remain part of scanned file bytes rather than extra APFS volume or snapshot totals. Metadata stores are walked again during JS smart rescans because directory mtimes do not establish that their file contents are unchanged. Coverage and sizes survive scan-history round trips.Failed or unobserved collection remains unavailable; partial counts are labeled incomplete. Unresolved mounts and older scans without recorded volume paths remain unavailable rather than inferring that stores are outside the scan. Native enumeration errors lack paths, so an unknown-path error conservatively prevents either category from claiming completeness. Guidance explains how to scan the relevant volume, grant Full Disk Access for privacy restrictions, and obtain an administrator's read-only measurement if root-only filesystem permissions still block access. The existing APFS card also keeps failed snapshot and purgeable-capacity collection distinct from an empty list or zero.
Optional guidance explains Apple's supported, root-only FSEvents retention API and its consequences for backup/sync clients, plus Spotlight exclusions, rebuilding, and the search tradeoff of disabling indexing. These are visibility and guidance changes: no purge, index deletion, indexing changes, privileged prompts, or helpers are added.
Overview categories and optional guidance — isolated macOS fixture
Validation was run locally on macOS; Playwright used Node 24 and isolated profiles/fixture trees.
bun run typecheckbun run test --maxWorkers=4cargo test --manifest-path native/diskhound-native-scanner/Cargo.tomlplaywright test e2e/mac-system-metadata.spec.ts e2e/shared-storage.spec.tsRegression coverage includes custom mounts under
/Users, both firmlink spellings, nested volumes, descendant scans, unresolved mounts, allocated sizes below hotspot limits, cross-category hardlinks, denied/partial collection, stores changing without directory-mtime changes, old history, snapshot/purgeable unknown states, and the native scanner-to-Overview flow. Category bytes are file allocation, not guaranteed reclaimable space; directory metadata, shared APFS blocks, and snapshots can differ from physical disk usage.