Skip to content

fix(a11y): restore dialog focus and record release blockers (VC-322) - #579

Draft
hussainph wants to merge 9 commits into
mainfrom
volli/VC-322-0-2-0-accessibility-and-motion-release-pass-keyb
Draft

hussainph wants to merge 9 commits into
mainfrom
volli/VC-322-0-2-0-accessibility-and-motion-release-pass-keyb

Conversation

@hussainph

@hussainph hussainph commented Sep 18, 2026 •

Copy link
Copy Markdown
Owner

Behavior

  • Restore keyboard focus to the New-ticket and command-palette invokers after dismissal, without overriding navigation handoff.
  • Add an opaque semantic keyboard-focus ring to the editable ticket title.
  • Cover dialog focus lifecycle, detached/null invokers, explicit handoff, and DOM-free rendering with regression tests.
  • Gate built-app dialog focus and title-ring regressions by default; broader accessibility measurements remain observational.

Integration

Merged current main, preserving the newer command-palette navigation rows and accessible name. Removed internal release investigation/checklist documents from the public repository.

Validation

  • pnpm exec vp check: passed.
  • Desktop package typecheck: passed.
  • Focused dialog, SSR, title, palette ordering, and ChromeBar tests: 12 passed.
  • Public-content check, both probe syntax checks, and git diff --check: passed.
  • Full coverage and desktop smokes are left to CI.

Draft remains held for owner review. This patch is not a full accessibility release sign-off; manual VoiceOver, reading-order, zoom, and broader motion acceptance remain separate owner gates.

@coderabbitai

coderabbitai Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hussainph

Copy link
Copy Markdown
Owner Author

Final-head verification: fc00c62 is green across Check + Test (including full protected coverage), boot smoke, all three smoke shards, and CodeQL. CI: https://github.com/hussainph/volli-code/actions/runs/35393188340 . The earlier seven CI timeout failures in the committed investigation are historical; final rerun passed without relaxing tests or thresholds. Draft remains held: actual VoiceOver speech/reading-order/scrollback acceptance, full manual matrix and VC-301 native browser keyboard routing remain open. Do not merge based on CI alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant