Skip to content

fix(pty): update Node to 24.21 for upstream Linux EOF fix (VC-639) - #751

Merged
hussainph merged 3 commits into
mainfrom
volli/VC-639-pty-shell-s-final-output-sometimes-missing-befor
Oct 5, 2026
Merged

hussainph merged 3 commits into
mainfrom
volli/VC-639-pty-shell-s-final-output-sometimes-missing-befor

Conversation

@hussainph

@hussainph hussainph commented Oct 5, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Pin .nvmrc and the host image to 24.21.0, the newest 24.x release in Node's release index. Update the image's tag and verified multi-arch digest together: sha256:0e0ff40c39bc087845bfb27465a0df4ea419520094bc35842ff83dd8cbe6f9b6.
  • Raise the supported floor to ^24.16.0, retaining the repository's caret/24.x convention. Keep engineStrict, development diagnostics, README, contributing/build docs, and host packaging docs consistent. Workflows already use .nvmrc or the root manifest; no explicit workflow version needs changing. hostd packages that exact Node binary.
  • Keep the real-shell 200kB output + UTF-8 tail before exit regression and the original bye-8 assertion unchanged.
  • vp run --filter @volli/docs check — 0 errors/warnings/hints.

Testing

Original validation includes vp check, git diff --check.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 91046a30-de26-4742-b845-0c875b744123
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hussainph hussainph changed the title fix(pty): preserve Linux shell tail before premature EOF (VC-639) fix(pty): update Node to 24.21 for upstream Linux EOF fix (VC-639) Oct 5, 2026
@hussainph
hussainph merged commit 3abede2 into main Oct 5, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant