Skip to content

fix(shared): preserve renderer MCP input frames under CSP (VC-636) - #852

Merged
hussainph merged 2 commits into
mainfrom
volli/VC-636-renderer-drops-session-input-recorded-frames-wit
Oct 13, 2026
Merged

hussainph merged 2 commits into
mainfrom
volli/VC-636-renderer-drops-session-input-recorded-frames-wit

Conversation

@hussainph

@hussainph hussainph commented Oct 12, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Preserve session.input.recorded tool-surface events containing MCP tools under the renderer's unchanged script-src 'self' CSP.
  • Add a separate browser-bundle VM regression (string/Wasm code generation disabled), covering default/draft-07/2019-09/2020-12 schemas, output schemas, parallel-read marks, and Code Mode routes. Also cover malformed wire shapes and unchanged host rejection of invalid schema semantics.
  • No new data is written, no protocol shape changes, no migration. 0.2.1 and 0.2.2-canary.1 read exactly the same data as before; an older affected renderer may still drop this frame under CSP, which this PR cannot retroactively repair.
  • No new exports or cross-ticket seams. Existing parseRendererSessionEvent is called by production packages/session-presentation/src/wire.ts:chatSessionFrame; the codec table now dispatches this payload to the renderer-only helper.

Testing

Original validation includes vp check, git diff --check.

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: b9f10134-e770-49c8-9634-b7cb7859f842
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hussainph
hussainph merged commit 75bd1ab into main Oct 13, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant