Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main merge and composer reconciliation
Merged
origin/main2661e1a with a normal merge commit 8cd8a36 (parents8c82aaab9,2661e1aa4), resolvingchat-plane.tsxandchat-plane.progress.test.tsx. This includes VC-774 (bb41a5c2c,44a5e04de,543bbf7a2) and VC-216 (#897). No rebase or force-push.Kept: VC-774's resident
idleSendsrecords,pendingIdleSends, receipt/refusal settlement, and pre-host bubble/Working bridge. They preserve the first message across attachment, queue-before-transcript gaps, idle/history reattachment, and view remounts. They are not just label suppression. Recovery Edit/Remove, explicit close, and queued-send acceptance/refusal still retire the right record.settledIdleSendIdsnames the existing completion predicate used by this bridge; ordinary held drafts now retire on host ownership without waiting for acceptance.Deleted:
transcriptDeliveryLabelsand its copied map that deleted labels for quiet sends; the cross-ownership wait clock (pendingSince,waitTimes,since, and VC-216'smountedAtmath); durable steering-label context;undeliveredRows/delivery-order tail; syntheticturn.started.commandIdacceptance; andRuntimeAttentionScrollHint.quietSendIdsis nowopeningSendIds: its remaining job is de-duplicating/placing the pre-host bubble and keeping Working visible, not hiding delivery labels. Local held-steer copy remains quiet as in current main.Behavior choice: durable mid-turn steering follows the transcript projection's order, above Working, without a delivery footer. There is no separate delivery-ordered tail. The pre-host composer and host queue behavior stay unchanged.
Verification on the merged commit
The unchanged VC-774 first-send, opening queue/turn handoff, history/closed-binding Enter, queue gap/remount, and recovery Edit/Remove cases all pass on the merged code. VC-216's obsolete assertion expecting durable Sending was updated to require no footer; its still-relevant local queue timing case remains.
Inherited lint blocker:
apps/desktop/src/renderer/src/components/settings/panes/updates-pane.tsx:102callsupdateStatus(state, Date.now())during render (react/purity). Confirmed the identical line exists inorigin/main; that file is not changed by this PR. No unrelated lint fix included. All changed-file lint and all requested typechecks pass. The first merged test run was 331 pass / 1 obsolete durable-Sending assertion failure; the final rerun above is 332/332.Drove it in the live app — merged code
Fresh verify-volli instance vd-f02651, built from clean merge commit 8cd8a36. The only mock was the external model HTTP boundary: a loopback fake scripted a real
session_startcall, streamed the child's first reply slowly, then returned HTTP 400 for a later user turn. Configured the isolated model through Settings; no internal setters/injected conversation or Attention state used as proof.Key commands (all actions and generations are in
transcript.jsonl):Results:
session_start; child 0e61e378 on DRV-1 was working during capture, with the parent recorded instartedBy.command.recordedat 12, uncorrelatedturn.startedat 13, no kickoff receipt. Screenshot shows kickoff above streaming assistant text with no Sending footer. Afterturn.completed16, the accepted receipt arrived at 17.turn.started19 →attention.raised(adapter_unrecoverable)21 →turn.interrupted22. Screenshot shows one stopped-failure recovery row. Scrolling up yields onlybutton "Scroll to latest", no floating error pill.list: no instances.Fresh evidence (local artifacts, not committed):
These supersede the stale-base screenshots from vd-479bb8. Screenshot upload is unavailable through this CLI; local artifacts are retained, not included in the public repository.
Ticket: VC-852