Skip to content

fix(agent-runtime): stop withholding images when credentials are loaded - #927

Merged
hussainph merged 2 commits into
mainfrom
volli/VC-857-stop-withholding-images-while-credentials-are-lo
Oct 18, 2026
Merged

hussainph merged 2 commits into
mainfrom
volli/VC-857-stop-withholding-images-while-credentials-are-lo

Conversation

@hussainph

@hussainph hussainph commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Stop withholding content images while credentials are loaded. Preserve only data on validated top-level content image blocks; redact metadata and extra fields normally.
  • Scrub image-shaped objects in details/structured data and malformed content blocks without exceptions, for both final results and partial updates.
  • Preserve text redaction and credential-aware shell spill suppression; update regression tests and documentation.

Ticket: VC-857

Local validation

Latest review fix:

  • vp test run src/pi/secrets-tool.test.ts --coverage --coverage.include=src/pi/secrets.ts (agent-runtime) — 63 tests passed; 100% statements, branches, functions, and lines in secrets.ts.
  • vp run --filter @volli/agent-runtime typecheck — passed.
  • vp check — passed.
  • node scripts/check-public-content.mjs — passed.
  • git diff --check — passed.

Before the review fix:

  • Agent-runtime vp test run — 92 files passed, 1 skipped; 2,580 tests passed, 4 skipped.
  • Agent-runtime/shared package typechecks — passed.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 45035761-566b-4ebc-bd76-58b555b5b3ab
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hussainph
hussainph force-pushed the volli/VC-857-stop-withholding-images-while-credentials-are-lo branch from 49ccdb4 to a1d121c Compare October 18, 2026 14:47
@hussainph
hussainph merged commit 7170501 into main Oct 18, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant